Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added missing 'alias:' prefix for repository name (#15563) #15902

Merged
merged 15 commits into from
Dec 5, 2023
Merged

fix: Added missing 'alias:' prefix for repository name (#15563) #15902

merged 15 commits into from
Dec 5, 2023

Conversation

ffppmm
Copy link
Contributor

@ffppmm ffppmm commented Oct 11, 2023 •
edited
Loading

Fixes #15563
Checklist:

  • this is a bug fix
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Added missing 'alias:' prefix for repository name as described here:

https://helm.sh/docs/chart_best_practices/dependencies/#repository-urls

@ffppmm ffppmm requested a review from a team as a code owner October 11, 2023 14:28
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0cb9980) 49.55% compared to head (f4c393a) 49.56%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15902   +/-   ##
=======================================
  Coverage   49.55%   49.56%           
=======================================
  Files         269      269           
  Lines       47245    47249    +4     
=======================================
+ Hits        23413    23417    +4     
  Misses      21532    21532           
  Partials     2300     2300

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffppmm
Copy link
Contributor Author

ffppmm commented Oct 12, 2023

Can somebody help me why 'Integration tests / Run end-to-end tests (v1.26.9)' is failing?

Regards Philipp

@ffppmm
Copy link
Contributor Author

ffppmm commented Oct 16, 2023

Can somebody help me why 'Integration tests / Run end-to-end tests (v1.26.9)' is failing?

Regards Philipp

SRY works now 😄

@ffppmm
Copy link
Contributor Author

ffppmm commented Nov 21, 2023 •
edited
Loading

Hi,

could anybody take a look at my request, I think this is a good addition to use alias and @ for repository dependency. Is there anything missing that I have to provide for getting my request merged?

Regards Philipp

@mashanm
Copy link

mashanm commented Dec 4, 2023

Can someone please review the PR ? It is a blocker for all charts with alias dependencies.

ishitasequeira
ishitasequeira approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ffppmm for raising the PR. LGTM!!

@ishitasequeira ishitasequeira merged commit 7484f1d into argoproj:master Dec 5, 2023
25 checks passed
@ffppmm ffppmm deleted the fix_alias branch December 5, 2023 07:38
@ffppmm
Copy link
Contributor Author

ffppmm commented Dec 5, 2023

Hi,
thanks a lot, very happy to contribute a useful addition to the, imho awesome, project 😄

Regards Philipp

@mashanm
Copy link

mashanm commented Dec 5, 2023

When can we expect this to be released ?

@ishitasequeira
Copy link
Member

/cherry-pick release-2.9

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 5, 2023
@ffppmm
Added missing 'alias:' prefix for repository name as described here: (#…
f2561b3 
…15902)
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Dec 5, 2023
Merged
ishitasequeira pushed a commit that referenced this pull request Dec 8, 2023
@gcp-cherry-pick-bot @ffppmm
Added missing 'alias:' prefix for repository name as described here: (#…
8436954 
…15902) (#16535)

Co-authored-by: ffppmm <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@ffppmm @vladfr
Added missing 'alias:' prefix for repository name as described here: (a…
5a7ca83 
…rgoproj#15902)
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@ffppmm @tesla59
Added missing 'alias:' prefix for repository name as described here: (a…
4995a88 
…rgoproj#15902)
@ffppmm
Copy link
Contributor Author

ffppmm commented Dec 19, 2023

Hi,

will this be in the current 2.10 Release?

Regards Philipp

JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
@ffppmm
Added missing 'alias:' prefix for repository name as described here: (a…
b32e218 
…rgoproj#15902)
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@ffppmm @lyda
Added missing 'alias:' prefix for repository name as described here: (a…
8366b09 
…rgoproj#15902)

Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@ffppmm @Hariharasuthan99
Added missing 'alias:' prefix for repository name as described here: (a…
e73349f 
…rgoproj#15902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alias: not working in repository reference in Chart.yaml
3 participants
@ffppmm @mashanm @ishitasequeira