Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias: not working in repository reference in Chart.yaml #15563

Closed
3 tasks done
ffppmm opened this issue Sep 19, 2023 · 3 comments · Fixed by #15902
Closed
3 tasks done

Alias: not working in repository reference in Chart.yaml #15563

ffppmm opened this issue Sep 19, 2023 · 3 comments · Fixed by #15902
Labels
bug Something isn't working

Comments

@ffppmm
Copy link
Contributor

ffppmm commented Sep 19, 2023

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

https://helm.sh/docs/chart_best_practices/dependencies/#repository-urls

If the repository has been added to the repository index file, the repository name can be used as an alias of URL. Use alias: or @ followed by repository names.

But in ArgoCD Code only @ ist considered, see the if.
https://github.com/argoproj/argo-cd/blob/master/reposerver/repository/repository.go#L1020

To Reproduce

Create a Chart.yaml with dependency repository: "alias:my-repo"

apiVersion: v2
name: my-app
version: 0.1
description: my-app
dependencies:
- name: some-dep
  version: 0.2.17
  repository: 'alias:my-repo'

Expected behavior

Repository works with helm dependency build

Version
v2.8.4
v2.7.14
Logs

Unable to save changes: application spec for my-app is invalid: InvalidSpecError: Unable to generate manifests in my-app: rpc error: code = Unknown desc = `helm dependency build` failed exit status 1: Error: could not find protocol handler for: alias

As mentioned here:
#7436 (comment)

Looking forward to a fix,
Regards Philipp

@ffppmm ffppmm added the bug Something isn't working label Sep 19, 2023
@ffppmm
Copy link
Contributor Author

ffppmm commented Sep 20, 2023

Hi,
it "should" be a small change, but maybe somebody who is far more experienced in go, ArgoCD behavior/processes and how to contribute can make a pull request (the checklist is very long):
ffppmm@b5fa9ee

Regards Philipp

@ffppmm
Copy link
Contributor Author

ffppmm commented Oct 16, 2023

Maybe this issue is related: #7436

@mashanm
Copy link

mashanm commented Dec 4, 2023

Thanks @ffppmm for the PR. Hope it gets merged soon! I guess the workaround is to use @reponame instead of alias:reponame while defining the dependency in the chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants