Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): not need send application if it is not under enabled namespaces (#14479) [release-2.7] #15474

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix(server): not need send application if it is not under enabled namespaces (#14479) [release-2.7] #15474

merged 1 commit into from
Sep 12, 2023

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Sep 12, 2023

Cherry-pick of #14479

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@pasha-codefresh @jannfis
fix(server): not need send application if it is not under enabled nam…
abddca2 
…espaces (argoproj#14479)

* fix: not need send application if it is not under enabled namespaces

* fix condition

* feat: Move application is permitted outside of watch function and cover with unit tests

* feat: Move application is permitted outside of watch function and cover with unit tests
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 68.18% and project coverage change: +0.02% 🎉

Comparison is base (67734db) 48.95% compared to head (abddca2) 48.98%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-2.7   #15474      +/-   ##
===============================================
+ Coverage        48.95%   48.98%   +0.02%     
===============================================
  Files              247      247              
  Lines            42934    42943       +9     
===============================================
+ Hits             21020    21035      +15     
+ Misses           19792    19785       -7     
- Partials          2122     2123       +1
Files Changed Coverage Δ
server/application/application.go 50.86% <68.18%> (+0.58%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannfis jannfis enabled auto-merge (squash) September 12, 2023 22:45
@jannfis jannfis merged commit 733bcab into argoproj:release-2.7 Sep 12, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

@ishitasequeira ishitasequeira Awaiting requested review from ishitasequeira

@crenshaw-dev crenshaw-dev Awaiting requested review from crenshaw-dev

@alexmt alexmt Awaiting requested review from alexmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jannfis @pasha-codefresh