fix(server): not need send application if it is not under enabled namespaces #14479
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14479 +/- ##
==========================================
- Coverage 49.79% 49.77% -0.02%
==========================================
Files 261 261
Lines 44751 44763 +12
==========================================
Hits 22283 22283
- Misses 20274 20288 +14
+ Partials 2194 2192 -2
☔ View full report in Codecov by Sentry. |
|
Can you add a unit test to cover this? Might be tricky since it's a Watch endpoint. If so, you could probably pull the |
|
Definitely |
|
@crenshaw-dev done |
…er with unit tests
… fix/watch-app-in-namespace
crenshaw-dev
changed the title
|
@crenshaw-dev could you please review again? |
|
/cherry-pick release-2.8 |
|
/cherry-pick release-2.7 |
|
/cherry-pick release-2.6 |
|
/cherry-pick release-2.5 |
…espaces (#14479) * fix: not need send application if it is not under enabled namespaces * fix condition * feat: Move application is permitted outside of watch function and cover with unit tests * feat: Move application is permitted outside of watch function and cover with unit tests
|
Cherry-pick failed with |
|
Cherry-pick failed with |
|
Cherry-pick failed with |
|
@pasha-codefresh would you mind opening cherry-pick PRs for release-2.5 through release-2.7? |
…espaces (#14479) (#14575) * fix: not need send application if it is not under enabled namespaces * fix condition * feat: Move application is permitted outside of watch function and cover with unit tests * feat: Move application is permitted outside of watch function and cover with unit tests Co-authored-by: pasha-codefresh <[email protected]>
|
I am not sure how to do it :( |
|
@pasha-codefresh something like this: git checkout release-2.7
git pull
git checkout -b release-2.7-ns-fix
git cherry-pick 2094404e0bdb759aaa8fd11be98ba2dacbf206f4
# resolve conflicts if necessary
git push # and then open a PR against release-2.7And then repeat for release-2.6 and release-2.5. It's tedious. :-) |
…espaces (argoproj#14479) * fix: not need send application if it is not under enabled namespaces * fix condition * feat: Move application is permitted outside of watch function and cover with unit tests * feat: Move application is permitted outside of watch function and cover with unit tests
…espaces (argoproj#14479) * fix: not need send application if it is not under enabled namespaces * fix condition * feat: Move application is permitted outside of watch function and cover with unit tests * feat: Move application is permitted outside of watch function and cover with unit tests
…espaces (#14479) (#15474) * fix: not need send application if it is not under enabled namespaces * fix condition * feat: Move application is permitted outside of watch function and cover with unit tests * feat: Move application is permitted outside of watch function and cover with unit tests Co-authored-by: pasha-codefresh <[email protected]>
…espaces (argoproj#14479) * fix: not need send application if it is not under enabled namespaces * fix condition * feat: Move application is permitted outside of watch function and cover with unit tests * feat: Move application is permitted outside of watch function and cover with unit tests
I have installed two argocd instances , and in one of them i can see applications that not part of enabled namespaces list.
This is response from application watch api
