Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI write support CMP (#11754) #12137

Merged

Conversation

schakrad
Copy link
Contributor

@schakrad schakrad commented Jan 25, 2023

Fixes #11754

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Screen Shot 2023-01-25 at 5 59 46 PM

Screen Shot 2023-01-25 at 6 00 20 PM

Screen Shot 2023-01-25 at 6 00 40 PM

@schakrad schakrad changed the title #11754 UI write support CMP feat-UI write support CMP #11754 Jan 25, 2023
@schakrad schakrad changed the title feat-UI write support CMP #11754 feat: UI write support CMP #11754 Jan 25, 2023
@crenshaw-dev crenshaw-dev changed the title feat: UI write support CMP #11754 feat: UI write support CMP (#11754) Jan 25, 2023
crenshaw-dev and others added 7 commits January 27, 2023 10:47
Signed-off-by: Michael Crenshaw <[email protected]>

better?

Signed-off-by: Michael Crenshaw <[email protected]>

fix silliness

Signed-off-by: Michael Crenshaw <[email protected]>

terrible hacks

Signed-off-by: Michael Crenshaw <[email protected]>

maybe better codegen

Signed-off-by: Michael Crenshaw <[email protected]>

fix tests

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakradari <[email protected]>
fix: pointers to param values
Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Patch coverage: 52.38% and project coverage change: +0.52 🎉

Comparison is base (4a06cb2) 47.46% compared to head (b4616db) 47.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12137      +/-   ##
==========================================
+ Coverage   47.46%   47.99%   +0.52%     
==========================================
  Files         246      246              
  Lines       41885    42221     +336     
==========================================
+ Hits        19879    20262     +383     
+ Misses      20008    19937      -71     
- Partials     1998     2022      +24     
Impacted Files Coverage Δ
applicationset/generators/cluster.go 80.27% <ø> (ø)
applicationset/services/scm_provider/gitea.go 69.15% <0.00%> (ø)
applicationset/utils/utils.go 75.59% <0.00%> (-5.09%) ⬇️
applicationset/webhook/webhook.go 65.71% <0.00%> (ø)
cmd/argocd/commands/admin/cluster.go 0.00% <ø> (ø)
controller/cache/cache.go 26.35% <0.00%> (-0.80%) ⬇️
.../apis/application/v1alpha1/applicationset_types.go 28.57% <ø> (ø)
pkg/apis/application/v1alpha1/repository_types.go 69.07% <ø> (-2.35%) ⬇️
pkg/apis/application/v1alpha1/types.go 58.38% <ø> (-0.65%) ⬇️
reposerver/cache/cache.go 61.02% <ø> (+1.02%) ⬆️
... and 24 more

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: schakradari <[email protected]>
@schakrad schakrad marked this pull request as ready for review January 31, 2023 17:22
schakrad and others added 5 commits February 1, 2023 16:41
Not needed for this PR.

Signed-off-by: schakrad <[email protected]>
…ture. It is the fix for Object options menu truncated in list view.

Signed-off-by: schakradari <[email protected]>
Reverting the change as this is not related to this PR.

Signed-off-by: schakrad <[email protected]>
@crenshaw-dev
Copy link
Member

@keithchong wondering if you have time to take a look at this. I plan to give it a thorough review to get this into 2.7, but that may be ~4wk from now. And I don't think I have the React chops to review the frontend well. :-)

@crenshaw-dev crenshaw-dev self-assigned this Feb 17, 2023
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just encountered a bug.

  1. In the Manifest tab, add a parameter with array: []
  2. Switch to the Parameters tab and click "Edit". Without making any changes, click "Save."
  3. Switch back to the Manifest tab. array: [] will have been replaced with map: {}.

We need the UI to keep track of the fact that the empty parameter is array-type instead of map-type.

@crenshaw-dev
Copy link
Member

Where the tooltip currently says "This parameter is provided by the plugin," could we add "It has been overridden in the Application manifest" where that's the case?

crenshaw-dev and others added 6 commits March 14, 2023 13:56
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakrad <[email protected]>
@crenshaw-dev crenshaw-dev merged commit faa7331 into argoproj:master Mar 21, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <[email protected]>

* CMP parameter changes

Signed-off-by: schakradari <[email protected]>

* fix: pointers to param values

Signed-off-by: Michael Crenshaw <[email protected]>

better?

Signed-off-by: Michael Crenshaw <[email protected]>

fix silliness

Signed-off-by: Michael Crenshaw <[email protected]>

terrible hacks

Signed-off-by: Michael Crenshaw <[email protected]>

maybe better codegen

Signed-off-by: Michael Crenshaw <[email protected]>

fix tests

Signed-off-by: Michael Crenshaw <[email protected]>

* same prefix issue fixed

Signed-off-by: schakradari <[email protected]>

* fix for delete param name

Signed-off-by: schakradari <[email protected]>

* lint changes

Signed-off-by: schakradari <[email protected]>

* lint fix

Signed-off-by: schakradari <[email protected]>

* lint fix

Signed-off-by: schakradari <[email protected]>

* finalChanges

Signed-off-by: schakradari <[email protected]>

* Delete application-resource-list.tsx

Not needed for this PR.

Signed-off-by: schakrad <[email protected]>

* added file which was deleted as it was not the change needed for this feature.

Signed-off-by: schakradari <[email protected]>

* refactored MapValuField and added fix for some edge cases

Signed-off-by: schakradari <[email protected]>

* Update application-resource-list.tsx

Reverting the change as this is not related to this PR.

Signed-off-by: schakrad <[email protected]>

* Reverting the change in application-resource-list

Signed-off-by: schakradari <[email protected]>

* Showing application parameter values irrespective of parameter present or not in plugin.yaml

Signed-off-by: schakradari <[email protected]>

* fix for lint errors

Signed-off-by: schakradari <[email protected]>

* fix false source mismatch

Signed-off-by: Michael Crenshaw <[email protected]>

* fix equals

Signed-off-by: Michael Crenshaw <[email protected]>

* fix swagger doc

Signed-off-by: Michael Crenshaw <[email protected]>

* Tooltip description change.

Signed-off-by: schakrad <[email protected]>

* fixed lint

Signed-off-by: schakrad <[email protected]>

* CMP fix for empty array.

Signed-off-by: schakrad <[email protected]>

---------

Signed-off-by: schakradari <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakrad <[email protected]>
Signed-off-by: schakrad <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

Add UI write support for CMP parameters
2 participants