-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI write support CMP (#11754) #12137
feat: UI write support CMP (#11754) #12137
Conversation
…pplicationListView. Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]> better? Signed-off-by: Michael Crenshaw <[email protected]> fix silliness Signed-off-by: Michael Crenshaw <[email protected]> terrible hacks Signed-off-by: Michael Crenshaw <[email protected]> maybe better codegen Signed-off-by: Michael Crenshaw <[email protected]> fix tests Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakradari <[email protected]>
fix: pointers to param values
Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #12137 +/- ##
==========================================
+ Coverage 47.46% 47.99% +0.52%
==========================================
Files 246 246
Lines 41885 42221 +336
==========================================
+ Hits 19879 20262 +383
+ Misses 20008 19937 -71
- Partials 1998 2022 +24
... and 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: schakradari <[email protected]>
Not needed for this PR. Signed-off-by: schakrad <[email protected]>
… feature. Signed-off-by: schakradari <[email protected]>
…ture. It is the fix for Object options menu truncated in list view. Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Reverting the change as this is not related to this PR. Signed-off-by: schakrad <[email protected]>
@keithchong wondering if you have time to take a look at this. I plan to give it a thorough review to get this into 2.7, but that may be ~4wk from now. And I don't think I have the React chops to review the frontend well. :-) |
Signed-off-by: schakradari <[email protected]>
…t or not in plugin.yaml Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
Signed-off-by: schakradari <[email protected]>
…gin_parameters Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just encountered a bug.
- In the
Manifest
tab, add a parameter witharray: []
- Switch to the
Parameters
tab and click "Edit". Without making any changes, click "Save." - Switch back to the
Manifest
tab.array: []
will have been replaced withmap: {}
.
We need the UI to keep track of the fact that the empty parameter is array-type instead of map-type.
Where the tooltip currently says "This parameter is provided by the plugin," could we add "It has been overridden in the Application manifest" where that's the case? |
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakrad <[email protected]>
…m/schakrad/argo-cd into ConfigManagementPlugin_parameters
Signed-off-by: schakrad <[email protected]>
Signed-off-by: schakrad <[email protected]>
* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * CMP parameter changes Signed-off-by: schakradari <[email protected]> * fix: pointers to param values Signed-off-by: Michael Crenshaw <[email protected]> better? Signed-off-by: Michael Crenshaw <[email protected]> fix silliness Signed-off-by: Michael Crenshaw <[email protected]> terrible hacks Signed-off-by: Michael Crenshaw <[email protected]> maybe better codegen Signed-off-by: Michael Crenshaw <[email protected]> fix tests Signed-off-by: Michael Crenshaw <[email protected]> * same prefix issue fixed Signed-off-by: schakradari <[email protected]> * fix for delete param name Signed-off-by: schakradari <[email protected]> * lint changes Signed-off-by: schakradari <[email protected]> * lint fix Signed-off-by: schakradari <[email protected]> * lint fix Signed-off-by: schakradari <[email protected]> * finalChanges Signed-off-by: schakradari <[email protected]> * Delete application-resource-list.tsx Not needed for this PR. Signed-off-by: schakrad <[email protected]> * added file which was deleted as it was not the change needed for this feature. Signed-off-by: schakradari <[email protected]> * refactored MapValuField and added fix for some edge cases Signed-off-by: schakradari <[email protected]> * Update application-resource-list.tsx Reverting the change as this is not related to this PR. Signed-off-by: schakrad <[email protected]> * Reverting the change in application-resource-list Signed-off-by: schakradari <[email protected]> * Showing application parameter values irrespective of parameter present or not in plugin.yaml Signed-off-by: schakradari <[email protected]> * fix for lint errors Signed-off-by: schakradari <[email protected]> * fix false source mismatch Signed-off-by: Michael Crenshaw <[email protected]> * fix equals Signed-off-by: Michael Crenshaw <[email protected]> * fix swagger doc Signed-off-by: Michael Crenshaw <[email protected]> * Tooltip description change. Signed-off-by: schakrad <[email protected]> * fixed lint Signed-off-by: schakrad <[email protected]> * CMP fix for empty array. Signed-off-by: schakrad <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: schakrad <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Fixes #11754
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: