Object Options Menu Truncated When Selected in Application Details View #11602

kmlamkin9 · 2022-12-07T23:48:14Z

Checklist:

I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
I've included steps to reproduce the bug.
I've pasted the output of argocd version.

Describe the bug

When I select the options menu on an object in the Application Details View, the menu options are truncated. I am unable to scroll the page to the right to see the options as well.

To Reproduce

Navigate to the Application Details List View and Select the options menu for any object.

Expected behavior

Menu should be readable to see what the options are.

Screenshots

Version

{
"Version": "v2.5.0+661afe0",
"BuildDate": "2022-12-07T19:52:27Z",
"GitCommit": "661afe0ad9653418aa0e3e2cc7939e42e0db40ab",
"GitTreeState": "clean",
"GoVersion": "go1.18.9",
"Compiler": "gc",
"Platform": "linux/amd64",
"KustomizeVersion": "v4.5.7 2022-08-02T16:35:54Z",
"HelmVersion": "v3.10.1+g9f88ccb",
"KubectlVersion": "v0.24.2",
"JsonnetVersion": "v0.19.1"
}

AND

{
"Version": "v2.5.4+86b2dde.dirty",
"BuildDate": "2022-12-07T15:18:19Z",
"GitCommit": "86b2dde8e4bf1187acd2b4294e94451cd104dad8",
"GitTreeState": "dirty",
"GoVersion": "go1.18.9",
"Compiler": "gc",
"Platform": "linux/amd64",
"KustomizeVersion": "v4.5.7 2022-08-02T16:35:54Z",
"HelmVersion": "v3.10.1+g9f88ccb",
"KubectlVersion": "v0.24.2",
"JsonnetVersion": "v0.18.0"
}

The text was updated successfully, but these errors were encountered:

schakrad · 2022-12-12T19:19:32Z

@kmlamkin9 I will work on this issue. Could you please assign me.

…pplicationListView. Signed-off-by: schakradari <[email protected]>

* #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * fix for the message to be fully shown under the events section. Signed-off-by: schakradari <[email protected]> * fixing lint Signed-off-by: schakradari <[email protected]> * Update application-resource-list.tsx Signed-off-by: schakrad <[email protected]> * fix for lint error Signed-off-by: schakradari <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]>

…pplicationListView. Signed-off-by: schakradari <[email protected]>

* #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * CMP parameter changes Signed-off-by: schakradari <[email protected]> * fix: pointers to param values Signed-off-by: Michael Crenshaw <[email protected]> better? Signed-off-by: Michael Crenshaw <[email protected]> fix silliness Signed-off-by: Michael Crenshaw <[email protected]> terrible hacks Signed-off-by: Michael Crenshaw <[email protected]> maybe better codegen Signed-off-by: Michael Crenshaw <[email protected]> fix tests Signed-off-by: Michael Crenshaw <[email protected]> * same prefix issue fixed Signed-off-by: schakradari <[email protected]> * fix for delete param name Signed-off-by: schakradari <[email protected]> * lint changes Signed-off-by: schakradari <[email protected]> * lint fix Signed-off-by: schakradari <[email protected]> * lint fix Signed-off-by: schakradari <[email protected]> * finalChanges Signed-off-by: schakradari <[email protected]> * Delete application-resource-list.tsx Not needed for this PR. Signed-off-by: schakrad <[email protected]> * added file which was deleted as it was not the change needed for this feature. Signed-off-by: schakradari <[email protected]> * refactored MapValuField and added fix for some edge cases Signed-off-by: schakradari <[email protected]> * Update application-resource-list.tsx Reverting the change as this is not related to this PR. Signed-off-by: schakrad <[email protected]> * Reverting the change in application-resource-list Signed-off-by: schakradari <[email protected]> * Showing application parameter values irrespective of parameter present or not in plugin.yaml Signed-off-by: schakradari <[email protected]> * fix for lint errors Signed-off-by: schakradari <[email protected]> * fix false source mismatch Signed-off-by: Michael Crenshaw <[email protected]> * fix equals Signed-off-by: Michael Crenshaw <[email protected]> * fix swagger doc Signed-off-by: Michael Crenshaw <[email protected]> * Tooltip description change. Signed-off-by: schakrad <[email protected]> * fixed lint Signed-off-by: schakrad <[email protected]> * CMP fix for empty array. Signed-off-by: schakrad <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: schakrad <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

* #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * extension.js should respect ARGOCD_SERVER_ENABLE_GZIP Signed-off-by: schakrad <[email protected]> * reverting the application-resource-list Signed-off-by: schakrad <[email protected]> * Update server/server.go Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

…tar ball of metrics extension (#13075) * #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * metrics-extension-change Signed-off-by: schakrad <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]>

…#14578) * #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * #11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * changes for argocd_rbac Signed-off-by: schakrad <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

…#14578) (#14581) * #11602 fix : Object options menu truncated when selected in ApplicationListView. * #11602 fix : Object options menu truncated when selected in ApplicationListView. * changes for argocd_rbac --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

…#14578) (#14582) * #11602 fix : Object options menu truncated when selected in ApplicationListView. * #11602 fix : Object options menu truncated when selected in ApplicationListView. * changes for argocd_rbac --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

…#14578) (#14583) * #11602 fix : Object options menu truncated when selected in ApplicationListView. * #11602 fix : Object options menu truncated when selected in ApplicationListView. * changes for argocd_rbac --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

…#14578) (#14584) * #11602 fix : Object options menu truncated when selected in ApplicationListView. * #11602 fix : Object options menu truncated when selected in ApplicationListView. * changes for argocd_rbac --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

…j#13911) (argoproj#14578) (argoproj#14582) * argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. * argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. * changes for argocd_rbac --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: schakrad <[email protected]>

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * CMP parameter changes Signed-off-by: schakradari <[email protected]> * fix: pointers to param values Signed-off-by: Michael Crenshaw <[email protected]> better? Signed-off-by: Michael Crenshaw <[email protected]> fix silliness Signed-off-by: Michael Crenshaw <[email protected]> terrible hacks Signed-off-by: Michael Crenshaw <[email protected]> maybe better codegen Signed-off-by: Michael Crenshaw <[email protected]> fix tests Signed-off-by: Michael Crenshaw <[email protected]> * same prefix issue fixed Signed-off-by: schakradari <[email protected]> * fix for delete param name Signed-off-by: schakradari <[email protected]> * lint changes Signed-off-by: schakradari <[email protected]> * lint fix Signed-off-by: schakradari <[email protected]> * lint fix Signed-off-by: schakradari <[email protected]> * finalChanges Signed-off-by: schakradari <[email protected]> * Delete application-resource-list.tsx Not needed for this PR. Signed-off-by: schakrad <[email protected]> * added file which was deleted as it was not the change needed for this feature. Signed-off-by: schakradari <[email protected]> * refactored MapValuField and added fix for some edge cases Signed-off-by: schakradari <[email protected]> * Update application-resource-list.tsx Reverting the change as this is not related to this PR. Signed-off-by: schakrad <[email protected]> * Reverting the change in application-resource-list Signed-off-by: schakradari <[email protected]> * Showing application parameter values irrespective of parameter present or not in plugin.yaml Signed-off-by: schakradari <[email protected]> * fix for lint errors Signed-off-by: schakradari <[email protected]> * fix false source mismatch Signed-off-by: Michael Crenshaw <[email protected]> * fix equals Signed-off-by: Michael Crenshaw <[email protected]> * fix swagger doc Signed-off-by: Michael Crenshaw <[email protected]> * Tooltip description change. Signed-off-by: schakrad <[email protected]> * fixed lint Signed-off-by: schakrad <[email protected]> * CMP fix for empty array. Signed-off-by: schakrad <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: schakrad <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

…j#12890) * argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * extension.js should respect ARGOCD_SERVER_ENABLE_GZIP Signed-off-by: schakrad <[email protected]> * reverting the application-resource-list Signed-off-by: schakrad <[email protected]> * Update server/server.go Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

…tar ball of metrics extension (argoproj#13075) * argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * metrics-extension-change Signed-off-by: schakrad <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]>

…j#13911) (argoproj#14578) * argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView. Signed-off-by: schakradari <[email protected]> * changes for argocd_rbac Signed-off-by: schakrad <[email protected]> --------- Signed-off-by: schakradari <[email protected]> Signed-off-by: schakrad <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>

kmlamkin9 added the bug Something isn't working label Dec 7, 2022

crenshaw-dev added the component:ui User interfaces bugs and enhancements label Dec 8, 2022

alexef assigned schakrad Dec 12, 2022

schakrad added a commit to schakrad/argo-cd that referenced this issue Dec 13, 2022

argoproj#11602 fix : Object options menu truncated when selected in A…

c7be1ee

…pplicationListView. Signed-off-by: schakradari <[email protected]>

alexef mentioned this issue Dec 22, 2022

ellipsis menu in list view should be right aligned instead of overflowing to the right #11804

Closed

schakrad added a commit to schakrad/argo-cd that referenced this issue Mar 16, 2023

argoproj#11602 fix : Object options menu truncated when selected in A…

130585c

…pplicationListView. Signed-off-by: schakradari <[email protected]>

gcp-cherry-pick-bot bot mentioned this issue Jul 18, 2023

fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (cherry-pick #14578) #14581

Merged

gcp-cherry-pick-bot bot mentioned this issue Jul 18, 2023

fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (cherry-pick #14578) #14582

Merged

gcp-cherry-pick-bot bot mentioned this issue Jul 18, 2023

fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (cherry-pick #14578) #14583

Merged

gcp-cherry-pick-bot bot mentioned this issue Jul 18, 2023

fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (cherry-pick #14578) #14584

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Object Options Menu Truncated When Selected in Application Details View #11602

Object Options Menu Truncated When Selected in Application Details View #11602

kmlamkin9 commented Dec 7, 2022 •

edited

Loading

schakrad commented Dec 12, 2022

Object Options Menu Truncated When Selected in Application Details View #11602

Object Options Menu Truncated When Selected in Application Details View #11602

Comments

kmlamkin9 commented Dec 7, 2022 • edited Loading

schakrad commented Dec 12, 2022

kmlamkin9 commented Dec 7, 2022 •

edited

Loading