Use kubernetes recommended labels #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recommended labels are the ones described here: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ The manifests labels should be in sync with the helm chart Also this is a follow up after the discussion from: #1035
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
=======================================
Coverage 35.98% 35.98%
=======================================
Files 59 59
Lines 8564 8564
=======================================
Hits 3082 3082
Misses 5026 5026
Partials 456 456Continue to review full report at Codecov.
|
|
I have to admit, I'm pretty confused by their documentation, since it appears to have conflicting information. I think this is the right thing to do but let me internalize their docs. I also have a big rework of the manifests, but will wait until this is in. |
jessesuen
approved these changes
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion over #1035 I made some changes on manifests labels.
This is in sync with the current kubernetes recommended labels:
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
Verified it like this: regenerated the manifests with running hack/update-manifests.sh and applied install.yaml on my minikube. Then I installed a redis and the guestbook app with ArgoCD.