upgrade argocd and add detail for minikube #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandawsonuk
commented
Apr 11, 2019
| @@ -20,7 +20,9 @@ helm install --kube-context="${KUBE_CONTEXT}" stable/jenkins \ | |||
| --name jenkins \ | |||
| --namespace jenkins \ | |||
| --set rbac.install=true \ | |||
| --version $JENKINS_CHART_VERSION | |||
| --version $JENKINS_CHART_VERSION \ | |||
| --set Master.AdminUser=$JENKINS_USER_NAME \ | |||
There was a problem hiding this comment.
this is just to set jenkins initial user out of the box
ryandawsonuk
commented
Apr 11, 2019
| @@ -11,5 +11,5 @@ source ${STARTUP_DIR}/../settings.sh | |||
| KUBECTL="kubectl --context=${KUBE_CONTEXT}" | |||
|
|
|||
| NAMESPACE_NAME=argocd | |||
| ${KUBECTL} logs -f $(kubectl --context="${KUBE_CONTEXT}" get pods -n ${NAMESPACE_NAME} -l app=argocd-server -o jsonpath='{.items[0].metadata.name}') -n ${NAMESPACE_NAME} | |||
| ${KUBECTL} logs -f $(kubectl --context="${KUBE_CONTEXT}" get pods -n ${NAMESPACE_NAME} -l app.kubernetes.io/name=argocd-server -o jsonpath='{.items[0].metadata.name}') -n ${NAMESPACE_NAME} | |||
There was a problem hiding this comment.
app.kubernetes.io/name is the new standard label format so argocd have switched to it
ryandawsonuk
changed the title
|
In 'examples/cicd-argocd/settings.sh.example' can we keep the jenkins credentials as set by the user and not use hardcoded ones incase they get copied by mistake. |
|
Have removed the jenkins user and password - the changes are now incorporated in #517 so closing this PR in favour of that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through this on minikube. I took latest ArgoCD version so have included changes to upgrade to latest ArgoCD. That includes changes to their labels (argoproj/argo-cd#1168) and I also had to change the setting autoprune as that isn't allowed without autosycn in the new version. Otherwise the changes are extra notes.