feat: Enhanced pod logs viewer. Fixes #6199 #11000 #10166

[alexec]

Fixes #6199
Fixes #11000
Fixes #10166

I've found the pod log viewer to be unusable. It's slow and works in a unintuitive manner. I can't sort my problems out with it.

• I want to know why my container is broken.
• I want to know why my container was broken.

This PR:

• The log viewer now essentially works in two mode - "follow" or "historical".
• In "follow" mode the logs are tailed.
• In "historical" mode you can choose a "since time" and number of lines to view.
• In both modes you can choose to filter by text.

The changes use the react-virtualization module so you can now scroll through thousands of log lines without crashing or slowing your browser.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (42d1c85) 47.79% compared to head (c0fad73) 47.78%.

❗ Current head c0fad73 differs from pull request most recent head cb52ad6. Consider uploading reports for the commit cb52ad6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11030      +/-   ##
==========================================
- Coverage   47.79%   47.78%   -0.02%     
==========================================
  Files         246      246              
  Lines       41968    41921      -47     
==========================================
- Hits        20058    20031      -27     
+ Misses      19910    19891      -19     
+ Partials     2000     1999       -1     

Impacted Files	Coverage Δ
applicationset/generators/matrix.go	69.74% <0.00%> (-7.76%)	⬇️
util/lua/lua.go	76.87% <0.00%> (-1.03%)	⬇️
util/git/creds.go	50.31% <0.00%> (-0.63%)	⬇️
cmpserver/plugin/plugin.go	78.51% <0.00%> (-0.50%)	⬇️
controller/appcontroller.go	52.62% <0.00%> (-0.42%)	⬇️
cmd/argocd/commands/app.go	21.49% <0.00%> (-0.02%)	⬇️
util/settings/settings.go	49.36% <0.00%> (ø)
applicationset/generators/cluster.go	80.27% <0.00%> (ø)
server/server.go	55.64% <0.00%> (+0.12%)	⬆️
pkg/apis/application/v1alpha1/types.go	59.02% <0.00%> (+0.48%)	⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[tooptoop4]

'Show the first 4 characters of the container name.' - what if 2 containers start with same prefix? current behavior of full name is handy

[alexec]

@rbreeze bump!

[alexec]

@rbreeze bump!

[alexec]

@michael12312 how do I escalate this PR? It's a small(ish) change. It is isolated to one part of the code. It'll make a big improvement is allow you to debug problems using Argo CD.

The current log viewer is nearly unusable.

[alexec]

Don't merge. Need to figure out what to do with the performance issue when many log lines.

[alexec]

@crenshaw-dev @rbreeze ready for review again.

changes made

[crenshaw-dev]

How difficult would it be to re-enable color handling in the logs?

[crenshaw-dev]

I'm not sure the search box makes sense for these three controls.

Even if it does make sense for the container dropdown, I think it should be hidden when there's only one container.

[alexec]

• Fixed colors.
• Changed the auto-completes into vanilla selects.
• Only show container selector when there is more than one container.

[alexec]

[alexec]

7 days from chatting with Jesse would be 4:30pm tomorrow.

[crenshaw-dev]

@jessesuen @rbreeze are y'all in alignment that this is the way to go?

[rbreeze]

LGTM, just one comment that can be addressed later: I miss the ability to quickly highlight a line copy it to the clipboard.

[rbreeze]

Where is this being used?

[jessesuen]

Yep directionally when I spoke with @alexec, I liked how this is more in line with the kubectl experience, so I support the change. As for the UI implementation, 🤷‍♂️

[alexec]

🥳

[dhirschfeld]

These improvements look great & I can't wait to try them out! 🚀

Being able to search more than 100 lines will make the logs much more useful.

I would've loved if my issue #11455 could have made the cut, but that'll keep for in future...

[rodrigc]

@alexec I'm trying the enhanced log viewer in Argo 2.7.2 and it looks great. Thanks for doing this!

One comment that I have is that the log viewer has a button to enable Dark Mode, but just for the log viewer.

One suggestion that I have is that the default behavior of Dark Mode for the log viewer
should be to inherit the setting for Dark Mode from /settings/appearance.

It is a bit weird to enable Dark Mode for the entire ArgoCD UI, but then have the Log Viewer be not in Dark Mode.

[alexec]

@rodrigc that is strange! Historical. You wanna fix?

[rodrigc]

@alexec I love ArgoCD, but don't have the bandwidth to fix this