-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show pod names
in log view adds undefined
prefix
#17704
Labels
bug
Something isn't working
Comments
I guess the issue is somewhere here, but I don't know how to debug this 😕 Also it was added in #11030. |
14 tasks
crenshaw-dev
pushed a commit
that referenced
this issue
Apr 2, 2024
… (#17706) * Fix color generation for pod name in logs viewer Signed-off-by: Philipp Trulson <[email protected]> * Add rebuy to users.md Signed-off-by: Philipp Trulson <[email protected]> --------- Signed-off-by: Philipp Trulson <[email protected]>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this issue
Apr 2, 2024
… (#17706) * Fix color generation for pod name in logs viewer Signed-off-by: Philipp Trulson <[email protected]> * Add rebuy to users.md Signed-off-by: Philipp Trulson <[email protected]> --------- Signed-off-by: Philipp Trulson <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this issue
Apr 2, 2024
… (#17706) (#17710) * Fix color generation for pod name in logs viewer * Add rebuy to users.md --------- Signed-off-by: Philipp Trulson <[email protected]> Co-authored-by: Philipp Trulson <[email protected]>
pasha-codefresh
added a commit
to codefresh-io/argo-cd
that referenced
this issue
May 14, 2024
* fix: elements should be optional (argoproj#17424) (argoproj#17510) A bug was reported, where an applicationset with an empty elements array, when created with `argocd appset create <filename>.yaml` gets a `...list.elements: Required value` error. My hypothesis is that when calling the K8s API, golang JSON marshalling mangles the empty `elements` array to `nil`, rather than creating an empty array when submitting the `POST`. Still need to figure out why the same setup seemingly works fine when the same appset is in an app-of-apps. Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> * Merge pull request from GHSA-jhwx-mhww-rgc3 * sec: limit helm index max size Signed-off-by: pashakostohrys <[email protected]> * sec: limit helm index max size Signed-off-by: pashakostohrys <[email protected]> * feat: fix tests and linter Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> * Bump version to 2.10.5 (argoproj#17654) Signed-off-by: GitHub <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * fix cosign (argoproj#17656) Signed-off-by: Justin Marquis <[email protected]> * chore(deps): bump webpack-dev-middleware from 5.3.1 to 5.3.4 in /ui (argoproj#17598) (argoproj#17686) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.1 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.1...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(ui): Fix color generation for pod name in logs viewer. Fixes argoproj#17704 (argoproj#17706) (argoproj#17710) * Fix color generation for pod name in logs viewer * Add rebuy to users.md --------- Signed-off-by: Philipp Trulson <[email protected]> Co-authored-by: Philipp Trulson <[email protected]> * fix: fix calculating patch for respect ignore diff feature (argoproj#17693) * test: unit test for respectIgnoreDifferences bug Signed-off-by: Jesse Suen <[email protected]> * test: simplify unit test Signed-off-by: Jesse Suen <[email protected]> * fix: fix calculating patch for respect ignore diff feature Signed-off-by: Alexander Matyushentsev <[email protected]> --------- Signed-off-by: Jesse Suen <[email protected]> Signed-off-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Jesse Suen <[email protected]> * fix(security): use Chainguard fork of git-urls (argoproj#17732) (argoproj#17735) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> * Bump version to 2.10.6 (argoproj#17744) Signed-off-by: GitHub <[email protected]> Co-authored-by: alexmt <[email protected]> * Merge pull request from GHSA-2gvw-w6fj-7m3c Signed-off-by: pashakostohrys <[email protected]> * Bump version to 2.10.7 (argoproj#17831) Signed-off-by: GitHub <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * fix: docker build fails due to "The repository 'http://deb.debian.org/debian buster-backports Release' does not have a Release file." Signed-off-by: pashakostohrys <[email protected]> * fix: codegen and e2e tests in release-2.10 (argoproj#17844) * fix: codegen and e2e tests Signed-off-by: pashakostohrys <[email protected]> * fix: codegen and e2e tests Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> * chore: upgrade redis to 7.0.15 (argoproj#17666) Upgrade to latest stable 7.0.x version to fix CVEs: CVE-2023-41056 Signed-off-by: Tais P. Hansen <[email protected]> * Merge pull request from GHSA-9m6p-x4h2-6frq * feat: limit jq.Run with timeout Signed-off-by: pashakostohrys <[email protected]> * feat: ignore normalizer jq execution timeout as env variable Signed-off-by: pashakostohrys <[email protected]> * feat: customize error message and add doc section Signed-off-by: pashakostohrys <[email protected]> * feat: improve log and change a way how to get variable Signed-off-by: pashakostohrys <[email protected]> * chore: fix import`s order Signed-off-by: pashakostohrys <[email protected]> * chore: rename variable inside sts Signed-off-by: pashakostohrys <[email protected]> * chore: fix import order Signed-off-by: pashakostohrys <[email protected]> * chore: fix import`s order Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> * Merge pull request from GHSA-9m6p-x4h2-6frq * feat: limit jq.Run with timeout Signed-off-by: pashakostohrys <[email protected]> * feat: ignore normalizer jq execution timeout as env variable Signed-off-by: pashakostohrys <[email protected]> * feat: customize error message and add doc section Signed-off-by: pashakostohrys <[email protected]> * feat: improve log and change a way how to get variable Signed-off-by: pashakostohrys <[email protected]> * chore: fix import`s order Signed-off-by: pashakostohrys <[email protected]> * chore: rename variable inside sts Signed-off-by: pashakostohrys <[email protected]> * chore: fix import order Signed-off-by: pashakostohrys <[email protected]> * chore: fix import`s order Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> * fix: codegen after security fix - 2.10 (argoproj#17985) * fix: codegen after security fix Signed-off-by: pashakostohrys <[email protected]> * fix: codegen after security fix Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> * Bump version to 2.10.8 (argoproj#17990) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * fix: enable sha256 and sha512 for git ssh (argoproj#18028) (argoproj#18029) * fix: bumping the knownhosts to v1.2.2 since this contains a fix that allows for sha256 and sha512 algorithms when using git ssh * chore: remove older version of module from go sum --------- Signed-off-by: Marc Arndt <[email protected]> Signed-off-by: Marc Arndt <[email protected]> Co-authored-by: Marc Arndt <[email protected]> Co-authored-by: Marc Arndt <[email protected]> * Bump version to 2.10.9 (argoproj#18033) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: jannfis <[email protected]> * fix: status.sync.comparedTo should use replace patch strategy (argoproj#18061) (argoproj#18075) * fix: status.sync.comparedTo should use replace patch strategy * add e2e tests --------- Signed-off-by: Alexander Matyushentsev <[email protected]> * chore: bump go-jose from 3.0.1 to 3.0.3 (argoproj#18102) Signed-off-by: Jayendra Parsai <[email protected]> Co-authored-by: Jayendra Parsai <[email protected]> * docs: fix 404 styling (argoproj#18094) (argoproj#18105) * docs: fix 404 styling * hack around custom tag destruction --------- Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> * chore: update gitops engine for force sync option (argoproj#5882) - 2.10 (argoproj#18123) Signed-off-by: pashakostohrys <[email protected]> * fix: Enable Redis authentication in the default installation * fix: linter issue * fix: linter issue --------- Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: GitHub <[email protected]> Signed-off-by: Justin Marquis <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Philipp Trulson <[email protected]> Signed-off-by: Jesse Suen <[email protected]> Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Tais P. Hansen <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Marc Arndt <[email protected]> Signed-off-by: Marc Arndt <[email protected]> Signed-off-by: Jayendra Parsai <[email protected]> Co-authored-by: gcp-cherry-pick-bot[bot] <98988430+gcp-cherry-pick-bot[bot]@users.noreply.github.com> Co-authored-by: Blake Pettersson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Justin Marquis <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Philipp Trulson <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Jesse Suen <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: alexmt <[email protected]> Co-authored-by: Tais P. Hansen <[email protected]> Co-authored-by: Marc Arndt <[email protected]> Co-authored-by: Marc Arndt <[email protected]> Co-authored-by: jannfis <[email protected]> Co-authored-by: Jayendra Parsai <[email protected]> Co-authored-by: Jayendra Parsai <[email protected]> Co-authored-by: May Zhang <[email protected]>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this issue
Jun 11, 2024
…proj#17704 (argoproj#17706) * Fix color generation for pod name in logs viewer Signed-off-by: Philipp Trulson <[email protected]> * Add rebuy to users.md Signed-off-by: Philipp Trulson <[email protected]> --------- Signed-off-by: Philipp Trulson <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this issue
Jun 16, 2024
…proj#17704 (argoproj#17706) * Fix color generation for pod name in logs viewer Signed-off-by: Philipp Trulson <[email protected]> * Add rebuy to users.md Signed-off-by: Philipp Trulson <[email protected]> --------- Signed-off-by: Philipp Trulson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist:
argocd version
.Describe the bug
After upgrading from 2.9.9 to 2.10.5 I wanted to inspect UI changes and tried the
Show pod names
button in the log view (https://argocd.example.com/applications/argocd/application?view=tree&resource=&node=%2FPod%2Fdefault%2Fapplication-77ffd685cc-hwqtj%2F0&tab=logs). However it always prefixes the pod name in the view withundefined
. After checking, I noticed that this issue existed on 2.9.9 already as well.In some cases, the pod name was displayed in color, e.g. red or blue. However 70% of the time it's white/black (depending on theme) with
undefined
in front of it. Maybe there is an issue in the code that generates the color of the pod name?To Reproduce
Logs
tabShow pod names
buttonundefined
in front of pod name in some casesI can't reliably reproduce it, as I said, sometimes the name is colored, sometimes it's not.
Expected behavior
Screenshots
Issue as described:
Sometimes it's working:
Version
Logs
Couldn't find any
The text was updated successfully, but these errors were encountered: