Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] argilla frontend: Avoid call router.push when opening an external URL #5675

Merged
merged 5 commits into from
Nov 7, 2024
Merged

[BUGFIX] argilla frontend: Avoid call router.push when opening an external URL #5675

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab3db01
debug: Show route on logs
frascuchon Nov 7, 2024
4336094
delete: Force server build
frascuchon Nov 7, 2024
78a8536
fix: Avoid push route when external==true
frascuchon Nov 7, 2024
c72b471
debug: remove console.log
frascuchon Nov 7, 2024
4ddd3a0
revert: remove me
frascuchon Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions argilla-frontend/v1/infrastructure/services/useRoutes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ export const useRoutes = () => {
} else {
window.location.href = where;
}
} else {
router.push(where);
}

router.push(where);
};

const getQuery = () => {
Expand Down
Loading