[BUGFIX] argilla frontend: Avoid call router.push when opening an external URL
#5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5675-ki24f765kq-no.a.run.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5675 +/- ##
===========================================
- Coverage 91.10% 91.08% -0.02%
===========================================
Files 150 150
Lines 6250 6250
===========================================
- Hits 5694 5693 -1
- Misses 556 557 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frascuchon
changed the title
argilla frontend: investigate weird spaces 404argilla frontend: Avoid call router.push when opening an external URL
frascuchon
commented
Nov 7, 2024
leiyre
approved these changes
Nov 7, 2024
frascuchon
deleted the
chore/argilla-frontend/investigate-weird-spaces-404
branch
frascuchon
added a commit
that referenced
this pull request
Nov 8, 2024
…xternal URL (#5675) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR fixes the `router.go` method and avoids calling `router.push` when the external flag is True **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
router.gomethod and avoids callingrouter.pushwhen the external flag is TrueType of change
How Has This Been Tested
Checklist