Output panel optimisation #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
reviewed
Jun 14, 2022
per1234
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
I tested with the build from 085f97e and this fixes both #68 and #405 for me.
In order to do a more thorough test of #68, I replaced the standard upload tool command with a script that prints 10000 lines of text. That results in a large delay between the completion of the upload process and the completion of printing to the Output panel when using the latest build from the main branch. Using the build from this PR, the output printing completes at the same time as the upload process.
Thanks Dave!
This was
linked to
issues
Jun 14, 2022
davegarthsimpson
requested review from
kittaakos
and removed request for
kittaakos
5 tasks
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Output panel prints slower than the CLI and on windows is out of sync with the upload operation.
Change description
Adds a simple buffer mechanism for the related stream from the CLI.
Other information
Optimisations on CLI side should also complement the resolution of this issue.
Reviewer checklist