Rate limit the number of outgoing gRPC messages #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should allow a better buffering of the outgoing gRPC messages (less messages with bigger data blocks -> less fragmentation). This should allow the clients (IDE) to better handle incoming data.
per1234
added
type: enhancement
|
This should be an alternative solution to arduino/arduino-ide#1058, would be nice to test it without that patch. |
umbynos
reviewed
Jun 15, 2022
umbynos
approved these changes
Jun 15, 2022
Co-authored-by: Umberto Baldi <[email protected]>
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
This change should allow a better buffering of the outgoing gRPC messages (fewer messages with bigger data blocks -> less fragmentation). This should allow the clients (IDE) to better handle incoming data.
What is the current behavior?
In particular on Windows, the output of the compile commands may be very fragmented, leading to a lot of small gRPC messages each one transporting just a single o few bytes.
What is the new behavior?
Messages are buffered and sent every 50 ms (unless an higher throughput is required).
Does this PR introduce a breaking change, and is titled accordingly?
No