Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant tests #301

Merged
merged 1 commit into from
Jul 23, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 0 additions & 133 deletions cli/cli_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
"fmt"
"io/ioutil"
"os"
"os/exec"
"path/filepath"
"testing"

Expand Down Expand Up @@ -288,138 +287,6 @@ func TestUploadIntegration(t *testing.T) {
require.NotZero(t, exitCode)
}

func TestLibUserIntegration(t *testing.T) {
// source of test custom libs
libDir := filepath.Join("testdata", "libs")
// install destination
libInstallDir := filepath.Join(currSketchbookDir, "libraries")
require.NoError(t, os.MkdirAll(libInstallDir, os.FileMode(0755)))
defer os.RemoveAll(libInstallDir)

installLib := func(lib string) {
cmd := exec.Command("cp", "-r", "-a", filepath.Join(libDir, lib), libInstallDir)
require.NoError(t, cmd.Run(), cmd.Args)
}

// List libraries (valid libs)
installLib("MyLib")
exitCode, d := executeWithArgs("lib", "list")
require.Zero(t, exitCode)
require.Contains(t, string(d), "MyLib")
require.Contains(t, string(d), "1.0.5")

// List libraries (pre-1.5 format)
installLib("MyLibPre15")
exitCode, d = executeWithArgs("lib", "list")
require.Zero(t, exitCode)
require.Contains(t, string(d), "MyLibPre15")

// List libraries (invalid version lib)
installLib("MyLibWithWrongVersion")
exitCode, d = executeWithArgs("lib", "list")
require.Zero(t, exitCode)
require.Contains(t, string(d), "MyLibWithWrongVersion")
}

func TestLibDownloadAndInstallIntegration(t *testing.T) {
exitCode, _ := executeWithArgs("core", "update-index")
require.Zero(t, exitCode)

// Download inexistent
exitCode, d := executeWithArgs("lib", "download", "inexistentLibrary", "--format", "json")
require.NotZero(t, exitCode)
require.Contains(t, string(d), "library inexistentLibrary not found")

exitCode, d = executeWithArgs("lib", "download", "inexistentLibrary")
require.NotZero(t, exitCode)
require.Contains(t, string(d), "library inexistentLibrary not found")

// Download latest
exitCode, d = executeWithArgs("lib", "download", "Audio")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Audio@")
require.Contains(t, string(d), "downloaded")

// Download non existent version
exitCode, d = executeWithArgs("lib", "download", "[email protected]")
require.NotZero(t, exitCode)
require.Contains(t, string(d), "not found")

// Install latest
exitCode, d = executeWithArgs("lib", "install", "Audio")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Audio@")
require.Contains(t, string(d), "Installed")

exitCode, d = executeWithArgs("lib", "list")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Audio")

// Already installed
exitCode, d = executeWithArgs("lib", "install", "Audio")
require.NotZero(t, exitCode)
require.Contains(t, string(d), "Audio@")
require.Contains(t, string(d), "already installed")

// Install another version
exitCode, d = executeWithArgs("lib", "install", "[email protected]")
require.Zero(t, exitCode)
require.Contains(t, string(d), "[email protected]")
require.Contains(t, string(d), "Installed")
exitCode, d = executeWithArgs("lib", "list")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Audio")
require.Contains(t, string(d), "1.0.4")

// List updatable
exitCode, d = executeWithArgs("lib", "list", "--updatable")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Audio")
require.Contains(t, string(d), "1.0.4")
require.Contains(t, string(d), "1.0.5")

// Uninstall version not installed
exitCode, d = executeWithArgs("lib", "uninstall", "[email protected]")
require.NotZero(t, exitCode)
require.Contains(t, string(d), "[email protected]")
require.Contains(t, string(d), "not installed")

// Upgrade libraries
exitCode, d = executeWithArgs("lib", "upgrade")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Installed")
require.Contains(t, string(d), "Audio")
require.Contains(t, string(d), "1.0.5")

// Uninstall (without version)
exitCode, d = executeWithArgs("lib", "uninstall", "Audio")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Uninstalling")
require.Contains(t, string(d), "Audio")
require.Contains(t, string(d), "1.0.5")
exitCode, d = executeWithArgs("lib", "list")
require.Zero(t, exitCode)
require.NotContains(t, string(d), "Audio")

// Uninstall (with version)
exitCode, d = executeWithArgs("lib", "install", "[email protected]")
require.Zero(t, exitCode)
require.Contains(t, string(d), "[email protected]")
require.Contains(t, string(d), "Installed")
exitCode, d = executeWithArgs("lib", "list")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Audio")
require.Contains(t, string(d), "1.0.4")
exitCode, d = executeWithArgs("lib", "uninstall", "[email protected]")
require.Zero(t, exitCode)
require.Contains(t, string(d), "Uninstalling")
require.Contains(t, string(d), "Audio")
require.Contains(t, string(d), "1.0.4")
exitCode, d = executeWithArgs("lib", "list")
require.Zero(t, exitCode)
require.NotContains(t, string(d), "Audio")
}

func TestSketchCommandsIntegration(t *testing.T) {
exitCode, _ := executeWithArgs("sketch", "new", "Test")
require.Zero(t, exitCode)
Expand Down