Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant tests #301

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Remove redundant tests #301

merged 1 commit into from
Jul 23, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 23, 2019

Remove integration tests that were ported to Python.

@cmaglie
Copy link
Member

cmaglie commented Jul 23, 2019

Tests running inside the go file have the advantage to add coverage.

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmaglie I guess we could add something like pytest-cov to the testing part, anyway this PR addresses integration testing (read: cli response to user command), so the coverage concept applied to this context needs to be developed more internally as we iterate on the project.
ATM we are leveraging the python ease of use to develop high level testing routines faster, and build a baseline of usecases to iterate with more speed having solid safe-net .

@masci
Copy link
Contributor Author

masci commented Jul 23, 2019

I'm going ahead and merge this because Go tests are outdated and failing while I need a clean run to setup Appveyor and I don't want to replicate fixes in two places at this stage.

@masci masci merged commit 15ee5b1 into master Jul 23, 2019
@masci masci deleted the massi/cleanup branch July 23, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants