Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for runtime.os upload property #1411

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Aug 24, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Adds integration tests to avoid regressions.

  • What is the current behavior?

N/A

  • What is the new behavior?

N/A

Nope.

  • Other information:

Add integration test to avoid breaking behaviour fixed by #1312 and closes #1198.


See how to contribute

@silvanocerza silvanocerza merged commit 9cc4eea into master Aug 24, 2021
@silvanocerza silvanocerza deleted the scerza/runtime-os-upload-prop-test branch August 24, 2021 15:53
@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed topic: testing labels Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{runtime.os} not being substituted in upload commandline for Sony SPRESENSE board
4 participants