Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add runtime.os property in upload sub-command #1312

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

nobonobo
Copy link
Contributor

@nobonobo nobonobo commented Jun 7, 2021

  • What kind of change does this PR introduce?

Bug fix for #1198

  • What is the current behavior?

arduino-cli upload command failed.
runtime.os property is not substituted for properties in upload sub-command execution.

  • What is the new behavior?

arduino-cli upload command will succeed.
runtime.os property substitute for properties.

  • Other information:

When you upload a program, it works as expected within Arduino IDE (V1.18.X) environment.
This fix improves the compatibility of the Arduino IDE (V1.18.X).

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2021

CLA assistant check
All committers have signed the CLA.

@nobonobo nobonobo changed the title add runtime.os property for upload sub-command add runtime.os property in upload sub-command Jun 7, 2021
@silvanocerza silvanocerza merged commit 64b14a5 into arduino:master Aug 24, 2021
@silvanocerza
Copy link
Contributor

@nobonobo thanks for the contribution. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants