Fix WiFiClient watchdog usage #211

BlooD2oo1 · 2022-02-14T23:13:21Z

Fix usage of watchdog function pointer in WiFiClient.
This solved the problem when I tried to send data to thingspeak.com but the internet is not available (wifi only).

CLAassistant · 2022-02-14T23:13:26Z

All committers have signed the CLA.

github-actions · 2022-02-14T23:31:11Z

Memory usage change @ aa04757

Board	flash	%	RAM for global variables	%
arduino:mbed_nano:nanorp2040connect	🔺 0 - +56	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:megaavr:uno2018:mode=on	🔺 0 - +30	0.0 - +0.06	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	🔺 0 - +56	0.0 - +0.02	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +56	0.0 - +0.02	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	🔺 0 - +56	0.0 - +0.02	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/AP_SimpleWebServer flash	%	examples/SimpleWebServerWiFi flash	%	examples/WiFiChatServer flash	%	examples/WiFiSSLClient flash	%	examples/WiFiWebClient flash	%	examples/WiFiWebClientRepeating flash	%	examples/WiFiWebServer flash	%
arduino:mbed_nano:nanorp2040connect	56	0.0	56	0.0	56	0.0	56	0.0	56	0.0	56	0.0	56	0.0
arduino:megaavr:uno2018:mode=on	30	0.06	20	0.04	20	0.04	20	0.04	20	0.04	20	0.04	20	0.04
arduino:samd:mkrvidor4000	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02
arduino:samd:mkrwifi1010	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02
arduino:samd:nano_33_iot	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02

Click for full report CSV

Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,56,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.0,0,0.0,0,0.0,0,0.0,56,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.0,0,0.0,56,0.0,0,0.0,56,0.0,0,0.0
arduino:megaavr:uno2018:mode=on,30,0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,20,0.04,0,0.0,20,0.04,0,0.0
arduino:samd:mkrvidor4000,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0
arduino:samd:mkrwifi1010,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0
arduino:samd:nano_33_iot,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0

### Releases v1.8.14-4 1. Fix bugs by using some unmerged PRs from original WiFiNINA, such as: - [WiFi.config - setting defaults as the Ethernet library #219](arduino-libraries/WiFiNINA#219) - [Fix WiFiClient watchdog usage #211](arduino-libraries/WiFiNINA#211) - [Watchdog trigger changes #208](arduino-libraries/WiFiNINA#208) - [added server.accept() #204](arduino-libraries/WiFiNINA#204) - [Fix PinStatus error on some platforms #185](arduino-libraries/WiFiNINA#185) 2. Add many WiFiMulti-related examples in [WiFiMulti](https://github.com/khoih-prog/WiFiNINA_Generic/tree/master/examples/WiFiMulti) 3. Update examples 4. Update `Packages' Patches`

github-actions · 2023-01-04T11:21:03Z

Memory usage change @ c9c1a52

Board	flash	%	RAM for global variables	%
arduino:mbed_nano:nanorp2040connect	🔺 0 - +56	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:megaavr:uno2018:mode=on	🔺 0 - +30	0.0 - +0.06	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	🔺 0 - +56	0.0 - +0.02	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +56	0.0 - +0.02	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	🔺 0 - +56	0.0 - +0.02	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/AP_SimpleWebServer flash	%	examples/SimpleWebServerWiFi flash	%	examples/WiFiChatServer flash	%	examples/WiFiSSLClient flash	%	examples/WiFiWebClient flash	%	examples/WiFiWebClientRepeating flash	%	examples/WiFiWebServer flash	%
arduino:mbed_nano:nanorp2040connect	56	0.0	56	0.0	56	0.0	56	0.0	56	0.0	56	0.0	56	0.0
arduino:megaavr:uno2018:mode=on	30	0.06	20	0.04	20	0.04	20	0.04	20	0.04	20	0.04	20	0.04
arduino:samd:mkrvidor4000	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02
arduino:samd:mkrwifi1010	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02
arduino:samd:nano_33_iot	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02	56	0.02

Click for full report CSV

Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,56,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.0,0,0.0,0,0.0,0,0.0,56,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.0,0,0.0,56,0.0,0,0.0,56,0.0,0,0.0
arduino:megaavr:uno2018:mode=on,30,0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,20,0.04,0,0.0,20,0.04,0,0.0
arduino:samd:mkrvidor4000,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0
arduino:samd:mkrwifi1010,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0
arduino:samd:nano_33_iot,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0

JAndrassy · 2023-01-04T11:22:50Z

the wait loops are superfluous. the fw call is blocking so there is no point to wait if the connection was not established in fw.
my PR #224 removes the wait loops

Fix WiFiClient watchdog usage

aa04757

per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 15, 2022

Merge branch 'arduino-libraries:master' into master

c9c1a52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix WiFiClient watchdog usage #211

Fix WiFiClient watchdog usage #211

BlooD2oo1 commented Feb 14, 2022

CLAassistant commented Feb 14, 2022 •

edited

Loading

github-actions bot commented Feb 14, 2022

github-actions bot commented Jan 4, 2023

JAndrassy commented Jan 4, 2023

Fix WiFiClient watchdog usage #211

Are you sure you want to change the base?

Fix WiFiClient watchdog usage #211

Conversation

BlooD2oo1 commented Feb 14, 2022

CLAassistant commented Feb 14, 2022 • edited Loading

github-actions bot commented Feb 14, 2022

github-actions bot commented Jan 4, 2023

JAndrassy commented Jan 4, 2023

CLAassistant commented Feb 14, 2022 •

edited

Loading