-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added server.accept() #204
Conversation
Memory usage change @ e1f3f5e
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE: Requested changes have all been made. Thanks!
✔️ Please add accept
to keywords.txt
.
It is true that accept
is already in the global keywords of the classic IDE, but that is tool-dependent and seems to have been added for a core method that was removed since then.
e1f3f5e
to
c784ef2
Compare
Memory usage change @ c784ef2
Click for full report table
Click for full report CSV
|
c784ef2
to
9ed76b2
Compare
Memory usage change @ 9ed76b2
Click for full report table
Click for full report CSV
|
6b62ba3
to
fdd46e1
Compare
Memory usage change @ fdd46e1
Click for full report table
Click for full report CSV
|
This is a very useful change, hope it becomes official soon. I have a webserver/websockets server that I need to port to the nano 33 iot, and cannot do it without this feature. |
hey everyone here, |
the PR in nina-fw repo is not merged yet |
### Releases v1.8.14-4 1. Fix bugs by using some unmerged PRs from original WiFiNINA, such as: - [WiFi.config - setting defaults as the Ethernet library #219](arduino-libraries/WiFiNINA#219) - [Fix WiFiClient watchdog usage #211](arduino-libraries/WiFiNINA#211) - [Watchdog trigger changes #208](arduino-libraries/WiFiNINA#208) - [added server.accept() #204](arduino-libraries/WiFiNINA#204) - [Fix PinStatus error on some platforms #185](arduino-libraries/WiFiNINA#185) 2. Add many WiFiMulti-related examples in [WiFiMulti](https://github.com/khoih-prog/WiFiNINA_Generic/tree/master/examples/WiFiMulti) 3. Update examples 4. Update `Packages' Patches`
### Releases v1.8.14-4 1. Fix bugs by using some unmerged PRs from original WiFiNINA, such as: - [WiFi.config - setting defaults as the Ethernet library #219](arduino-libraries/WiFiNINA#219) - [Fix WiFiClient watchdog usage #211](arduino-libraries/WiFiNINA#211) - [Watchdog trigger changes #208](arduino-libraries/WiFiNINA#208) - [added server.accept() #204](arduino-libraries/WiFiNINA#204) - [Fix PinStatus error on some platforms #185](arduino-libraries/WiFiNINA#185) 2. Add many WiFiMulti-related examples in [WiFiMulti](https://github.com/khoih-prog/WiFiNINA_Generic/tree/master/examples/WiFiMulti) 3. Update examples 4. Update `Packages' Patches`
### Releases v1.8.14-4 1. Fix bugs by using some unmerged PRs from original WiFiNINA, such as: - [WiFi.config - setting defaults as the Ethernet library #219](arduino-libraries/WiFiNINA#219) - [Fix WiFiClient watchdog usage #211](arduino-libraries/WiFiNINA#211) - [Watchdog trigger changes #208](arduino-libraries/WiFiNINA#208) - [added server.accept() #204](arduino-libraries/WiFiNINA#204) - [Fix PinStatus error on some platforms #185](arduino-libraries/WiFiNINA#185) 2. Add many WiFiMulti-related examples in [WiFiMulti](https://github.com/khoih-prog/WiFiNINA_Generic/tree/master/examples/WiFiMulti) 3. Update examples 4. Update `Packages' Patches`
Hi all, I can establish a connection with telnet but not with an FTP client. Please try to verify this soon. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JAndrassy Testing the WiFiAdvanchedChatServer.ino
example i'm getting some strange result. Can you please double check it?
The server is running on a Nano33IoT with NINA FW 1.5.0 and i'm running the Ethernet TelnetClient.ino
on a MKRWiFi1010 + MKRETH SHIELD.
Once the client is connected to the server i'm writing 3 messages from the client serial monitor: Hi!
How are you?
All good!
and this is the output i get.
WiFiAdvanchedChatServer:
Attempting to connect to SSID: 0_0
Chat server address:192.168.8.244
We have a new client #0
We have a new client #1
We have a new client #2
We have a new client #3
We have a new client #4
We have a new client #5
TelnetClient:
Connecting…
Connected
Hi!
Hello, client number: 0
Hello, client number: 1
I!
How are you?
Hello, client number: 2
HHoowwHello, client number: 3
aaarrreee you?
you?
you?
All good!
Hello, client number: 4
AAAAllllllll ggggHello, client number: 5
Ooooooooood!
d!
d!
d!
d!
Running the standard WiFiChat server i get this.
WiFiChatServer
Attempting to connect to SSID: 0_0
SSID: 0_0 IP Address: 192.168.8.244
signal strength (RSSI):-73 dBm
We have a new client
Hi!
How are you?
All good!
TelnetClient:
Connecting…
Connected
Hi!
Hello, client!
Hi!
How are you?
How are you?
All good!
All good!
sorry, the 1.5.0 from the release page doesn't have the server.accept() support. The PR was merged only after the version was build and tagged. |
fdd46e1
to
32217c3
Compare
Memory usage change @ 32217c3
Click for full report table
Click for full report CSV
|
32217c3
to
dbc0631
Compare
I added documentation into api.md. It is based on the Ethernet library's server.accept documentatiom |
dbc0631
to
12c33f1
Compare
The PR was destroyed by GitHub Sync function, when I today attempted to sync the old branch for server.accept() with current master to get the current version of api.md. My attempts to recover it failed. Sorry. New PR #257 |
Depends on nina-fw PR arduino/nina-fw#79
This PR adds server.accept() function as documented for the Ethernet library.
https://www.arduino.cc/en/Reference/EthernetServerAccept
If server.accept() is used with older firmware it will behave as available(), because the accept parameter in SPI request will be ignored.
The PR contains the
accept()
example WiFiAdvancedChatServer ported from Ethernet library.