-
-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Fetcher interface in docs #933
Conversation
@zcei: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
e7def9c
to
35753d3
Compare
35753d3
to
094896b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this!
@freiksenet maybe? You merged the PR that introduced this behavior as well 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @zcei - thanks!
As mentioned in #891, the docs for a custom fetcher are off since a couple of months.
After c91e577 landed, the types were changed to accept a
DocumentNode
instead of astring
.TODO:
If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)Make sure all of the significant new logic is covered by testsMake sure all tests and linter rules pass