Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema introspection with node-fetch breaking change in 2.23.1 #683

Closed
gaelollivier opened this issue Mar 19, 2018 · 3 comments
Closed

Schema introspection with node-fetch breaking change in 2.23.1 #683

gaelollivier opened this issue Mar 19, 2018 · 3 comments
Labels
docs Focuses on documentation changes

Comments

@gaelollivier
Copy link
Contributor

gaelollivier commented Mar 19, 2018

It seems that commit c91e577 introduces a breaking change in using introspectSchema with a custom fetcher, such as node-fetch.
The code in the documentation would break, since query is now a parsed AST instead of a string, resulting in an object being sent.

I'm not sure this commit should have been published as a patch since it introduces a breaking change.

Side note: This change actually broke a build on the project I'm working on and allowed me to find an issue with my Dockerfile which was not properly using yarn.lock ^^'

@purdrew
Copy link

purdrew commented Mar 26, 2018

Ran into the same issue on my project. Thankfully the fix on my end is minimal but definitely should not have been a patch release and the documentation should be updated.

@stubailo stubailo added the docs Focuses on documentation changes label Jul 13, 2018
@stubailo
Copy link
Contributor

We should make sure the docs are correct.

@hwillson
Copy link
Contributor

hwillson commented Sep 7, 2018

Fixed in #933 - thanks!

@hwillson hwillson closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Focuses on documentation changes
Projects
None yet
Development

No branches or pull requests

4 participants