-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TrustServerCertificate on AzSqlDatabaseMigration #434
feat: TrustServerCertificate on AzSqlDatabaseMigration #434
Conversation
Added TrustServerCertificate for scenario's where you want to build locally for integration testing.
✅ Deploy Preview for arcus-scripting canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🥇 only one small comment
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
I see an issue in the integration test execution in the Azure Devops Pipeline:
Interestingly this fails on Linux but the same integration test works on Windows... |
I'll look into it |
TrustServerCertificate was introduced in version 22
|
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Approved and merged! |
Added TrustServerCertificate for scenario's where you want to build locally for integration testing.