Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TrustServerCertificate on AzSqlDatabaseMigration #434

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

LodewijkSioen
Copy link
Contributor

Added TrustServerCertificate for scenario's where you want to build locally for integration testing.

Added TrustServerCertificate for scenario's where you want to build locally for integration testing.
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for arcus-scripting canceled.

Name Link
🔨 Latest commit a6afc15
🔍 Latest deploy log https://app.netlify.com/sites/arcus-scripting/deploys/66e96ade4140d10008b41f64

@pim-simons pim-simons changed the title TrustServerCertificate on AzSqlDatabaseMigration feat: TrustServerCertificate on AzSqlDatabaseMigration Sep 17, 2024
Copy link
Contributor

@pim-simons pim-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🥇 only one small comment

docs/preview/03-Features/powershell/azure-sql.md Outdated Show resolved Hide resolved
@pim-simons
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pim-simons
Copy link
Contributor

I see an issue in the integration test execution in the Azure Devops Pipeline:

Execute dummy SQL statement to make sure the Azure SQL DB is resumed.
Task failed. Attempt 1. Will retry in next 1 seconds. Error: A parameter cannot be found that matches parameter name 'TrustServerCertificate'.
Task failed. Attempt 2. Will retry in next 1 seconds. Error: A parameter cannot be found that matches parameter name 'TrustServerCertificate'.
Task failed. Attempt 3. Will retry in next 1 seconds. Error: A parameter cannot be found that matches parameter name 'TrustServerCertificate'.
Task failed. Attempt 4. Will retry in next 1 seconds. Error: A parameter cannot be found that matches parameter name 'TrustServerCertificate'.
[-] Describe Arcus Azure SQL integration tests failed
WriteErrorException: Task failed. With all 5 attempts. Error: System.Management.Automation.ParameterBindingException: A parameter cannot be found that matches parameter name 'TrustServerCertificate'.
at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame) A parameter cannot be found that matches parameter name 'TrustServerCertificate'.
at global:Retry-Function, /home/vsts/work/1/s/src/Arcus.Scripting.Tests.Integration/Arcus.Scripting.Sql.tests.ps1:88
at , /home/vsts/work/1/s/src/Arcus.Scripting.Tests.Integration/Arcus.Scripting.Sql.tests.ps1:127

Interestingly this fails on Linux but the same integration test works on Windows...

@LodewijkSioen
Copy link
Contributor Author

I'll look into it

TrustServerCertificate was introduced in version 22
@LodewijkSioen
Copy link
Contributor Author

TrustServerCertificate was introduced in version 22 of the SqlServer module. I Updated the RequiredModules to the latest version to be sure.

@pim-simons
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@pim-simons pim-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pim-simons pim-simons merged commit de395da into arcus-azure:main Sep 17, 2024
50 checks passed
@LodewijkSioen LodewijkSioen deleted the add-trustservercertificate branch September 17, 2024 14:04
@pim-simons
Copy link
Contributor

Approved and merged!
Thanks for your contribution 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants