Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TrustServerCertificate param to Arcus.Scripting.Sql #433

Closed
LodewijkSioen opened this issue Sep 17, 2024 · 4 comments
Closed

Add TrustServerCertificate param to Arcus.Scripting.Sql #433

LodewijkSioen opened this issue Sep 17, 2024 · 4 comments
Labels
area:sql All issues related to Azure SQL enhancement New feature or request
Milestone

Comments

@LodewijkSioen
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I would like to use Arcus.Scripting.Sql to build up a local database for integration testing. However: recently the default for TrustServerCertificate has flipped from true to false. Arcus.Scripting.Sql does not provide a parameter to control this.

Describe the solution you'd like
An extra parameter that exposes TrustServerCertificate

Describe alternatives you've considered
Setting up certificates 😒

@github-project-automation github-project-automation bot moved this to To do in Roadmap Sep 17, 2024
@stijnmoreels stijnmoreels added this to the v1.4.0 milestone Sep 17, 2024
@stijnmoreels stijnmoreels added enhancement New feature or request area:sql All issues related to Azure SQL labels Sep 17, 2024
@stijnmoreels
Copy link
Member

Great that you use Arcus.Scripting for this. Are you up to implement this yourself? We can guide you through the process.

@LodewijkSioen
Copy link
Contributor Author

I'm cloning the repo and installing the powershell tooling as we speak ;)
I've already found the Contributing docs, but if there are other guidelines for a PR, let me know.

@stijnmoreels
Copy link
Member

I'm cloning the repo and installing the powershell tooling as we speak ;) I've already found the Contributing docs, but if there are other guidelines for a PR, let me know.

That's the most important one, the thing for PR's is that we place everything together (code changes + tests + docs) and not in separate PR's. But that's it.

Ping me or @pim-simons if you experience any trouble and thx a lot! 🤩

@LodewijkSioen
Copy link
Contributor Author

Merged in #434

@github-project-automation github-project-automation bot moved this from To do to Done in Roadmap Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sql All issues related to Azure SQL enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants