chore: remove deprecated request functionality #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-observability canceled.
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
==========================================
- Coverage 85.71% 85.58% -0.14%
==========================================
Files 71 71
Lines 3095 2955 -140
Branches 217 194 -23
==========================================
- Hits 2653 2529 -124
- Misses 365 366 +1
+ Partials 77 60 -17
☔ View full report in Codecov by Sentry. |
|
It looks like we're using some obsolete 'LogMetric' and other obsolete Log Dependency methods here. We should replace them by the non-obsolete methods |
fgheysels
reviewed
Oct 10, 2023
src/Arcus.Observability.Tests.Integration/Serilog/TelemetryTypeFilterTests.cs
Show resolved
Hide resolved
All in good time #398, #404, #401, #424, #428... it was too big to remove all in a single PR, that's why this PR only handles the deprecated request-related functionality. |
fgheysels
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated functionality related to request tracking in preperation to the v3 release.
Closes #404
Closes #397