Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated RequestLogEntry constructors without start time #397

Closed
stijnmoreels opened this issue Jun 13, 2022 · 0 comments · Fixed by #543
Closed

Remove deprecated RequestLogEntry constructors without start time #397

stijnmoreels opened this issue Jun 13, 2022 · 0 comments · Fixed by #543
Assignees
@stijnmoreels
Labels
breaking-change All issues that require to do a breaking chnage good first issue Good for newcomers requests All issues related to requests
Milestone
v3.0.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
Previously, we were tracking requests with the UTC Now start time but we have replaced this with the DurationMeasurement type.

Describe the solution you'd like
Remove the deprecated constructors of the RequestLogEntry type that doesn't have any start time.
@stijnmoreels stijnmoreels added good first issue Good for newcomers requests All issues related to requests breaking-change All issues that require to do a breaking chnage labels Jun 13, 2022
@stijnmoreels stijnmoreels added this to the v3.0.0 milestone Jun 13, 2022
@stijnmoreels stijnmoreels modified the milestones: v3.0.0, v4.0.0 Sep 15, 2023
@stijnmoreels stijnmoreels self-assigned this Oct 10, 2023
@stijnmoreels stijnmoreels mentioned this issue Oct 10, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in Roadmap Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
breaking-change All issues that require to do a breaking chnage good first issue Good for newcomers requests All issues related to requests
Projects
Roadmap
Status: Done
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

chore: remove deprecated request functionality stijnmoreels/arcus.observability
1 participant
@stijnmoreels