Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine request telemetry Source based on SourceSystem #246

Closed
stijnmoreels opened this issue Oct 12, 2021 · 1 comment
Closed

Determine request telemetry Source based on SourceSystem #246

stijnmoreels opened this issue Oct 12, 2021 · 1 comment
Assignees
Labels
application-insights All issues related to Azure Application Insights requests All issues related to requests service-to-service-correlation All issues related to service-to-service correlation.
Milestone

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
When we can track Azure Service Bus types #242 and we have SourceSystem in our request tracking model #244 , we should determine the Source of the request tracking telemetry.

Describe the solution you'd like
We should only provide a source when the SourceSystem is an Azure Service Bus type, otherwise the URL should be filled in with the request host and request URI.

We should make sure that this is future-proof, so we can add additional types later. This source system is better to be an enumeration or other strict type so we can control the different types.

Additional context
https://github.com/arcus-azure/arcus-service-to-service-correlation-poc

@stijnmoreels stijnmoreels added application-insights All issues related to Azure Application Insights requests All issues related to requests service-to-service-correlation All issues related to service-to-service correlation. labels Oct 12, 2021
@stijnmoreels stijnmoreels added this to the v2.4.0 milestone Oct 12, 2021
@stijnmoreels stijnmoreels self-assigned this Jan 21, 2022
@stijnmoreels
Copy link
Member Author

Done via #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-insights All issues related to Azure Application Insights requests All issues related to requests service-to-service-correlation All issues related to service-to-service correlation.
Projects
None yet
Development

No branches or pull requests

1 participant