Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support to track Azure Service Bus requests #242

Closed
5 tasks done
stijnmoreels opened this issue Oct 12, 2021 · 0 comments · Fixed by #250
Closed
5 tasks done

Provide support to track Azure Service Bus requests #242

stijnmoreels opened this issue Oct 12, 2021 · 0 comments · Fixed by #250
Assignees
Labels
application-insights All issues related to Azure Application Insights correlation All issues related to correlating telemetry service-to-service-correlation All issues related to service-to-service correlation.
Milestone

Comments

@stijnmoreels
Copy link
Member

stijnmoreels commented Oct 12, 2021

Is your feature request related to a problem? Please describe.
Our .LogRequest functionality only takes into account HTTP requests and no other types. This is troublesome if we want to link Azure Service Bus resources to a service-to-service correlation.

Describe the solution you'd like
We should provide support to track Azure Service Bus requests. This change will require some additions and changes:

  • Add logging extension .LogAzureServiceBusRequest specific for Azure Service Bus requests which should take in:
    • Azure Service Bus entity name
    • Azure Service Bus namespace
    • Operation name (default to Process)
  • Add ServiceBus-Entity in the telemetry context with the Azure Service Bus entity name
  • Add ServiceBus-Endpoint in the telemetry context with the following format:
    type:Azure Service Bus | name:{entityName} | endpoint:sb://{namespaceEndpoint}.servicebus.windows.net/
  • Use Azure Service Bus as SourceSystem of the request telemetry.
  • Use operation name as SourceName of the request telemetry.

Note that HTTP-specific properties in the request telemetry should be filled-out, but not with anything important.

Additional context
Azure Service Bus telemetry tracking in the official Application Insights SDK
Service-to-service poc

@stijnmoreels stijnmoreels added application-insights All issues related to Azure Application Insights correlation All issues related to correlating telemetry service-to-service-correlation All issues related to service-to-service correlation. labels Oct 12, 2021
@stijnmoreels stijnmoreels added this to the v2.4.0 milestone Oct 12, 2021
@stijnmoreels stijnmoreels self-assigned this Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-insights All issues related to Azure Application Insights correlation All issues related to correlating telemetry service-to-service-correlation All issues related to service-to-service correlation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant