Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide SourceSystem and SourceName to request telemetry model #244

Closed
stijnmoreels opened this issue Oct 12, 2021 · 4 comments · Fixed by #269
Closed

Provide SourceSystem and SourceName to request telemetry model #244

stijnmoreels opened this issue Oct 12, 2021 · 4 comments · Fixed by #269
Assignees
Labels
application-insights All issues related to Azure Application Insights requests All issues related to requests service-to-service-correlation All issues related to service-to-service correlation.
Milestone

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
We should provide a SourceSystem and SourceName to the request telemetry when tracking requests, as they are required when distinguishing between HTTP requests and other types that needs to be tracked.

Describe the solution you'd like
Add a SourceSystem = "HTTP" and SourceName = method + uri property to the request telemetry model.
Make sure that it can be overwritten for other types but is fixed when tracking HTTP requests.

Additional context
https://github.com/arcus-azure/arcus-service-to-service-correlation-poc

@stijnmoreels stijnmoreels added application-insights All issues related to Azure Application Insights requests All issues related to requests service-to-service-correlation All issues related to service-to-service correlation. labels Oct 12, 2021
@stijnmoreels stijnmoreels added this to the v2.4.0 milestone Oct 12, 2021
@tomkerkhove
Copy link
Contributor

Can you elaborate on this please? I'm not really sure what we are trying to achieve here?

@stijnmoreels
Copy link
Member Author

Can you elaborate on this please? I'm not really sure what we are trying to achieve here?

We have to pass along an indication whether we're tracking HTTP requests or Azure Service Bus (or other types) requests. The SourceSystem was something you put in place to distinguish between the two. The SourceName is something that was also missing.

@tomkerkhove
Copy link
Contributor

I don't recall that so I'm happy that you are here :p

@stijnmoreels
Copy link
Member Author

Related to #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-insights All issues related to Azure Application Insights requests All issues related to requests service-to-service-correlation All issues related to service-to-service correlation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants