-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Django (and related packages) to 4.2 #9866
Upgrade Django (and related packages) to 4.2 #9866
Conversation
@chiatt A handful of changes will be needed in projects e.g. afs (similar replacements of I already have them prepared but haven't PR'd them to afs because it looks like afs isn't targeting Arches 7.5 yet. |
Update arches project template to use path()
Update django-related dependencies to versions supporting Django 4.0.
Refs elastic/elasticsearch-py#1698 Also replace deprecated ignore param.
Update django-related dependencies to versions supporting Django 4.1.
Update django-related dependencies to versions supporting Django 4.2.
125f701
to
cdace46
Compare
Thanks @jacobtylerwalls, could you document those changes in the release notes ( |
Done! Should I also add the elastic changes this PR added to address deprecations? I don't know to what extent users are managing that themselves. We can also handle it later when actually upgrading elastic, but we might forget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Thanks for pushing this over the line! |
Types of changes
Description of Change
Django 3.2 will be end-of-life in April 2024. Since Arches 7.5 is an LTS, require the current Django LTS (4.2).
Upgrade Django-related dependencies.
Require Python 3.8 (see related docs update).
Fix some (not all) deprecation warnings to make it easier to get a clean test run with
python -Werror manage.py test
. Some deprecations are left for #9832 when Python 3.11 will be required.Issues Solved
Closes #9799
Checklist
Ticket Background
Further comments
This is probably easier to review commit by commit.
Upgrade instructions
In addition to usual steps like reinstalling all dependencies and running migrations, consider also:
python manage.py makemigrations
(before running migrations)USE_L10N
settingDEFAULT_FILE_STORAGE
toSTORAGES["default"]["BACKEND"]