Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation docs with typo and consistency fixes #357

Merged

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Aug 1, 2023

brief description of changes

  • Fix typos
  • myproject -> my_project per previous steps of tutorial
  • Use full path to requirements.txt
  • Link to stable versions of Django docs (so that we are not continually updating 1.11 -> 2.x -> 3.x etc.)
  • Update url() examples to use path() (deprecated in Django 3.1)
  • Suggest Python 3.8 as minimum (due to importlib_metadata issue)

issues addressed

Closes #356

This box must be checked

  • the PR branch was originally made from the base branch

This box should be checked

  • after these changes the docs build locally without error (there are unrelated errors before my changes...)

This box should only be checked you intend to follow through on it (we can do it on our end too)

  • I will cherry-pick all commits in this PR into other branches that should have them after this PR is merged

url() was deprecated in Django 3.1
As of October 2022, a transitive dependency (importlib_metadata)
is not compatible with Python 3.7.

Python 3.7's EOL date was June 27, 2023.
@ekansa
Copy link
Collaborator

ekansa commented Aug 2, 2023

@jacobtylerwalls this looks good to me! Thanks for the updates. I think they are very helpful!!

@ekansa ekansa merged commit b4d01a9 into archesproject:master Aug 2, 2023
@jacobtylerwalls jacobtylerwalls deleted the master_fix_typos_and_install_docs branch August 2, 2023 17:36
@jacobtylerwalls
Copy link
Member Author

Glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to 7.4 installation instructions
2 participants