Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes errors when creating provisional edits #9704

Merged
merged 11 commits into from
Jul 7, 2023
Merged

Fixes errors when creating provisional edits #9704

merged 11 commits into from
Jul 7, 2023

Conversation

chrabyrd
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

#9648

@chrabyrd chrabyrd requested a review from chiatt June 29, 2023 21:14
chiatt
chiatt requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good, but the migration didn't seem to work for me. I added a suggestion inline that seems to work ok.

arches/app/models/migrations/9648_add_empty_key_value_pairs_to_tiles.py Show resolved Hide resolved
arches/app/datatypes/datatypes.py Show resolved Hide resolved
chiatt
chiatt approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chiatt chiatt merged commit 10c40d7 into dev/7.5.x Jul 7, 2023
@chiatt chiatt deleted the 9648_prevent_prov_edit_errors branch July 7, 2023 22:55
@chiatt chiatt mentioned this pull request Jul 12, 2023
Closed
@jacobtylerwalls jacobtylerwalls mentioned this pull request Oct 10, 2023
Merged
3 tasks
@chiatt chiatt mentioned this pull request Oct 20, 2023
Closed
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

Assignees

@chiatt chiatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrabyrd @chiatt