Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provisional edits for grouping cards break the resource & report pages #9648

Closed
johnatawnclementawn opened this issue Jun 13, 2023 · 0 comments
Closed

Provisional edits for grouping cards break the resource & report pages #9648

johnatawnclementawn opened this issue Jun 13, 2023 · 0 comments
Labels
Type: Bug Something isn't working

Comments

@johnatawnclementawn
Copy link
Member

johnatawnclementawn commented Jun 13, 2023 •
edited
Loading

Requirements to reproduce:

  1. Resource with n>0 grouping cards
  2. Access to both provisional user & resource reviewer accounts

Steps to reproduce:

  1. With the provisional user account, create a resource & add data to the grouping card tiles
  2. With the resource reviewer account, visit http://localhost:8000/report/ or http://localhost:8000/resource/
  3. Observe broken page

Screenshots:

  1. Provisional Editor: 'boolean' is a grouping card encompassing number & string
    ProvisionalEditor

  2. Resource Reviewer:
    ResourceReviewer
@johnatawnclementawn johnatawnclementawn added the Type: Bug Something isn't working label Jun 13, 2023
@chiatt chiatt added this to pipeline Jun 13, 2023
@chiatt chiatt self-assigned this Jun 13, 2023
@chiatt chiatt moved this to 🏗 In Progress in pipeline Jun 13, 2023
@chiatt chiatt moved this from 🏗 In Progress to 📋 Backlog in pipeline Jun 14, 2023
@chiatt chiatt removed their assignment Jun 14, 2023
chiatt added a commit that referenced this issue Jun 27, 2023
@chiatt
Simplify value check, re #9648
f1c6d60
chiatt added a commit that referenced this issue Jun 27, 2023
@chiatt
Add check for prov tiles to model, re #9648
bc5551c
chrabyrd added a commit that referenced this issue Jun 29, 2023
@chrabyrd
creates empty key/value pairs for all nodes in a tile #9648
b27a04d
chrabyrd added a commit that referenced this issue Jun 29, 2023
@chrabyrd
adds migration for tiledata #9648
46f6754
chrabyrd added a commit that referenced this issue Jun 29, 2023
@chrabyrd
nit #9648
62e0caf
@chrabyrd chrabyrd mentioned this issue Jun 29, 2023
Merged
3 tasks
chrabyrd added a commit that referenced this issue Jun 30, 2023
@chrabyrd
updates failing tests #9648"
ad12852 
gst
chrabyrd added a commit that referenced this issue Jun 30, 2023
@chrabyrd
fixes failing tests #9648
faa9294
chrabyrd added a commit that referenced this issue Jul 4, 2023
@chrabyrd
updates base datatype get_tile_data #9648
4b02d35
chrabyrd added a commit that referenced this issue Jul 5, 2023
@chrabyrd
updates datatype index command to handle TypeError #9648
ac4c58a
chrabyrd added a commit that referenced this issue Jul 7, 2023
@chrabyrd
PR changes #9648
49a2d6f
chrabyrd added a commit that referenced this issue Jul 7, 2023
@chrabyrd
reverses changes to tests since updating TileModel.save logic #9648
efe7769
@chiatt chiatt closed this as completed Jul 7, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in pipeline Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
pipeline
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chiatt @johnatawnclementawn