Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project typescript linter doesn't find types exported from core arches #11234

Closed
jacobtylerwalls opened this issue Jul 23, 2024 · 3 comments
Closed
Assignees

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Jul 23, 2024

#11210 added the following type to core arches, as a baby step to prove out shipping types that projects/arches applications such as the controlled list manager will find useful:

export type Language = {
code: string;
default_direction: "ltr" | "rtl";
id: number;
isdefault: boolean;
name: string;
scope: string;
};

However, this import, which worked in #10569 when part of arches core:

import type { Language } from "@/arches/types";

Fails (at the ts linter only, not the bundle) in an arches application (archesproject/arches-references@9fa562a) with:

arches_references/src/arches-references/utils.ts:4:31 - error TS2307: Cannot find module '@/arches/types' or its corresponding type declarations.

4 import type { Language } from "@/arches/types";
                                ~~~~~~~~~~~~~~~~

[6:02:58 PM] Found 12 errors. Watching for file changes.
@chrabyrd
Copy link
Contributor

chrabyrd commented Jul 23, 2024

ah, but aren't there different errors when appending .ts to types? Similarly I'm pretty sure all vue components must be appended with .vue

@jacobtylerwalls
Copy link
Member Author

For sure. I wrote up my findings in the PR, let me know what you think!

@jacobtylerwalls
Copy link
Member Author

Now being tracked in #11253

@jacobtylerwalls jacobtylerwalls closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Jul 31, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Controlled List Manager Jul 31, 2024
@jacobtylerwalls jacobtylerwalls removed their assignment Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

No branches or pull requests

2 participants