Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript pre-commit hook file inclusion #11249 #11250

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jul 30, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Before, the ts pre-commit hook had trouble finding files for two reasons:

This second issue was worked around by using bash to bail out of the pre-commit context that provides a list of staged files only.

Now, also add the check-hooks-apply meta hook to ensure the checks are operative.

Issues Solved

Closes #11249

@jacobtylerwalls jacobtylerwalls changed the title [WIP] Improve ts pre-commit hook #11249 Fix typescript pre-commit hook file inclusion #11249 Aug 13, 2024
@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review August 13, 2024 17:21
Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  • tested core Arches standalone
  • tested new project (initialized from updated templates)

@johnatawnclementawn johnatawnclementawn merged commit 8e56af2 into dev/7.6.x Aug 14, 2024
7 checks passed
@johnatawnclementawn johnatawnclementawn deleted the jtw/ts-pre-commit-fix branch August 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-commit out of the box ts linting does not seem to check files
2 participants