Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

photo-gallery-card Issues #11022

Closed
csmith-he opened this issue Jun 10, 2024 · 0 comments · Fixed by #11026
Closed

photo-gallery-card Issues #11022

csmith-he opened this issue Jun 10, 2024 · 0 comments · Fixed by #11026
Assignees
@csmith-he

Comments

@csmith-he
Copy link
Contributor

csmith-he commented Jun 10, 2024 •
edited
Loading

The following issues have been noted (as part of the Arches for HERs work) with the photo-gallery-card:

  • File limit set in the widget configuration is not reflected in the text on screen
  • File types set in the widget configuration are not reflected in the text on screen
  • Even when file types are specified, any type of file can be uploaded and no alert is raised to point out when incorrect formats are loaded.
@csmith-he csmith-he self-assigned this Jun 10, 2024
@chiatt chiatt added this to pipeline Jun 10, 2024
@csmith-he csmith-he mentioned this issue Jun 11, 2024
Merged
11 tasks
@csmith-he csmith-he linked a pull request Jun 11, 2024 that will close this issue
#11022 Photo Gallery Card fixes #11026
Merged
11 tasks
This was referenced Jun 11, 2024
Closed
Closed
@jacobtylerwalls jacobtylerwalls moved this to 👀 In Review in pipeline Jun 13, 2024
csmith-he added a commit that referenced this issue Jun 19, 2024
@csmith-he
Merge pull request #11026 from HistoricEngland/11022_photo_gallery_ca…
8c5bbe1 
…rd_fixes

#11022 Photo Gallery Card fixes
@chiatt chiatt closed this as completed Jun 19, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csmith-he csmith-he

Labels
None yet
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#11022 Photo Gallery Card fixes HistoricEngland/arches
2 participants
@chiatt @csmith-he