Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node aliases not nullable #10437

Closed
jacobtylerwalls opened this issue Dec 14, 2023 · 0 comments · Fixed by #11600
Closed

Make node aliases not nullable #10437

jacobtylerwalls opened this issue Dec 14, 2023 · 0 comments · Fixed by #11600
Assignees
@jacobtylerwalls
Labels
Type: Bug Something isn't working

Comments

@jacobtylerwalls
Copy link
Member

Node aliases are supposed to be unique per graph, but the uniqueness doesn't extend to None -- and since alias is nullable, you can have multiple nodes per graph without an alias.

Suggesting to write a migration that generates missing aliases and sets the field to be not-nullable going forward.
@chiatt chiatt added this to pipeline Dec 14, 2023
@chiatt chiatt added the Type: Bug Something isn't working label Dec 21, 2023
@chiatt chiatt moved this to 📋 Backlog in pipeline Dec 21, 2023
@jacobtylerwalls jacobtylerwalls self-assigned this Nov 1, 2024
@jacobtylerwalls jacobtylerwalls moved this from 📋 Backlog to 🏗 In Progress in pipeline Nov 1, 2024
jacobtylerwalls added a commit that referenced this issue Nov 1, 2024
@jacobtylerwalls
Make node aliases not nullable #10437
49a97e3
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Nov 1, 2024
jacobtylerwalls added a commit that referenced this issue Nov 1, 2024
@jacobtylerwalls
fixup! Make node aliases not nullable #10437
ea0d34a
jacobtylerwalls added a commit that referenced this issue Nov 1, 2024
@jacobtylerwalls
Make node aliases not nullable #10437
3b5130d
@jacobtylerwalls jacobtylerwalls mentioned this issue Nov 1, 2024
Merged
11 tasks
jacobtylerwalls added a commit that referenced this issue Nov 1, 2024
@jacobtylerwalls
nit re #10437
eb75778
johnatawnclementawn pushed a commit that referenced this issue Nov 5, 2024
@jacobtylerwalls
Make node aliases not nullable #10437 (#11600)
7298732
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
Type: Bug Something isn't working
Projects
pipeline
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make node aliases not nullable #10437 archesproject/arches
2 participants
@chiatt @jacobtylerwalls