fixup! Make node aliases not nullable #10437

arches/app/models/models.py

@@ -904,9 +904,13 @@ def __init__(self, *args, **kwargs):
         if not self.nodeid:
             self.nodeid = uuid.uuid4()
 
-    def save(self, *args, **kwargs):
-        if self.alias is None:
+    def clean(self):
+        if not self.alias:
             Graph.objects.get(pk=self.graph_id).create_node_alias(self)
+
+    def save(self, **kwargs):
+        if not self.alias:
+            self.clean()
             add_to_update_fields(kwargs, "alias")
         if self.pk == self.source_identifier_id:
             self.source_identifier_id = None

releases/8.0.0.md

@@ -60,6 +60,9 @@ JavaScript:
 
 - `ensure_userprofile_exists()` was removed from the `Tile` model.
 
+- The following fields are no longer nullable. If you have custom SQL (or Python code that uses direct ORM operations to bypass model methods, etc.), you will need to set these fields directly on creation:
+    - `Node.alias`
+
 ### Upgrading Arches
 
 1. You must be upgraded to at least version   before proceeding. If you are on an earlier version, please refer to the upgrade process in the []()

tests/models/node_tests.py

@@ -0,0 +1,11 @@
+from arches.app.models.graph import Graph
+from arches.app.models.models import Node
+from tests.base_test import ArchesTestCase
+
+
+class NodeTests(ArchesTestCase):
+    def test_missing_alias_supplied(self):
+        new_graph = Graph.new(name="Missing alias test")
+        new_node = Node(graph_id=new_graph.pk)
+        new_node.clean()
+        self.assertIsNotNone(new_node.alias)