Add utils for ranking and finding labels #2
Conversation
jacobtylerwalls
force-pushed
the
jtw/rank-label
branch
from
8568eb4 to
eae5b95
Compare
jacobtylerwalls
force-pushed
the
jtw/rank-label
branch
from
971c2e4 to
3b6cd6f
Compare
jacobtylerwalls
force-pushed
the
jtw/rank-label
branch
from
3b6cd6f to
42f86d1
Compare
There was a problem hiding this comment.
Looks good! Few small comments && I noticed that test coverage decreased by ~2%. If it's easy enough I'd say shore it up but I'm not super worried about it.
Neither here nor there but I bleh I hate having 2 sources of truth for a thing 🤢 . Let's just hope the python label ranking util doesn't change much, or if it does we're cognizant enough to also update this.
| } from "@/arches_vue_utils/types"; | ||
|
|
||
| /* Port of rank_label in arches.app.utils.i18n python module */ | ||
| export const rankLabel = ( |
There was a problem hiding this comment.
non-blocking nit: I've started developing a pretty strong opinion about function declarations vs function expressions. It really doesn't matter in this context but if you've also got strong opinions in general it'd be fun to chat 😄
| export interface WithLabels { | ||
| labels: Label[]; | ||
| } | ||
|
|
||
| export interface WithValues { | ||
| values: Label[]; | ||
| } | ||
|
|
||
| export type Labellable = WithLabels | WithValues; |
There was a problem hiding this comment.
not blocking but if these types end up getting used elsewhere I'd say we update them to be a touch more descriptive eg (ItemWithLabels)
but not too worried about it now 👍
There was a problem hiding this comment.
I hear you. I don't think they'll get used elsewhere. What's been maddeningly difficult here is that "item" has a technical meaning in the controlled list manager, so I was hoping to avoid that.
Implementation and test cases inspired by
arches.app.utils.i18npython module