Use label finder util from arches-vue-utils #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
chrabyrd
reviewed
Oct 2, 2024
arches_references/src/arches_references/components/tree/PresentationControls.vue
Outdated
Show resolved
Hide resolved
|
oh just noticed the failing builds. Does the TS config need to be updated as well? |
|
I just merged some stuffs to arches-references, let me give it another kick |
jacobtylerwalls
force-pushed
the
jtw/use-label-finder-util
branch
from
8822c9a to
12c6fcc
Compare
archesproject/arches-vue-utils#2 needs merging, or I should update this branch to point to it, but that seems like avoidable churn. |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on archesproject/arches-vue-utils#2
Partner to archesproject/arches-lingo#93