Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open downloaded project files in a new tab #1339 #1371

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Open downloaded project files in a new tab #1339 #1371

merged 2 commits into from
Oct 23, 2023

Conversation

jacobtylerwalls
Copy link
Member

Closes #1339

Testing instructions

  • take two samples
  • upload XY data for sample one using a format like png that is browser-displayable
  • upload XY data for sample two using a format like docx that is not
  • Project Report workflow: use both links in the download project files step, ensure the site doesn't hang up

@jacobtylerwalls jacobtylerwalls changed the title Open downloaded files in a new tab #1339 Open downloaded project files in a new tab #1339 Oct 19, 2023
@chiatt chiatt linked an issue Oct 19, 2023 that may be closed by this pull request
Report workflow: Clicking link to downloaded file hangs #1339
Closed
aarongundel
aarongundel approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobtylerwalls jacobtylerwalls merged commit 12ccce1 into dev/1.1.x Oct 23, 2023
1 check passed
@jacobtylerwalls jacobtylerwalls deleted the 1339-report-file-new-tab branch October 23, 2023 21:16
@jacobtylerwalls jacobtylerwalls mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongundel aarongundel aarongundel approved these changes

Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report workflow: Clicking link to downloaded file hangs
2 participants
@jacobtylerwalls @aarongundel