Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report workflow: Clicking link to downloaded file hangs #1339

Closed
jacobtylerwalls opened this issue Oct 9, 2023 · 2 comments · Fixed by #1371
Closed

Report workflow: Clicking link to downloaded file hangs #1339

jacobtylerwalls opened this issue Oct 9, 2023 · 2 comments · Fixed by #1371
Assignees
@jacobtylerwalls

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Oct 9, 2023 •
edited
Loading

Report workflow:

  1. Advance to Download Files Step
  2. Click the link to a downloaded file

Result: hangs

Clicking back button: also hangs

Screenshot 2023-10-04 at 6 14 23 PM
@chiatt chiatt moved this to 🔖 Ready in afs-pipeline Oct 11, 2023
@jacobtylerwalls jacobtylerwalls self-assigned this Oct 19, 2023
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in afs-pipeline Oct 19, 2023
@jacobtylerwalls
Copy link
Member Author

It's possible the original issue with displaying the png was due to corruption fixed by #1362 or something similar, but I can still reproduce with document formats that browsers cannot display like .docx.

Suggesting we just open these files in a new tab, which should do the right thing automagically.

jacobtylerwalls added a commit that referenced this issue Oct 19, 2023
@jacobtylerwalls
Open downloaded files in a new tab #1339
71f066e
@jacobtylerwalls jacobtylerwalls mentioned this issue Oct 19, 2023
Merged
4 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in afs-pipeline Oct 19, 2023
@chiatt chiatt linked a pull request Oct 19, 2023 that will close this issue
Open downloaded project files in a new tab #1339 #1371
Merged
4 tasks
jacobtylerwalls added a commit that referenced this issue Oct 23, 2023
@jacobtylerwalls
Open downloaded files in a new tab #1339
2370b83
@jacobtylerwalls
Copy link
Member Author

Fixed in #1371

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in afs-pipeline Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
afs-pipeline
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open downloaded project files in a new tab #1339 archesproject/arches-for-science
1 participant
@jacobtylerwalls