fix for chemical analysis workflow #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiatt
requested changes
Oct 13, 2023
arches_for_science/views/s3.py
Outdated
Comment on lines
134
to
135
| #fields = dict(('x-amz-meta-{}'.format(key[9:len(key)-1]), value) for (key, value) in all_items if key.startswith('metadata') and key != 'metadata[type]') | ||
| #fields['content-type'] = content_type |
arches_for_science/views/s3.py
Outdated
|
|
||
| @method_decorator(can_edit_resource_instance, name="dispatch") | ||
| class S3UploadView(BaseManagerView): | ||
| """""" |
chiatt
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes various issues with the chemical analysis workflow/uppy implementation.
On dragging a new file in to be uploaded, that file will first be created in arches and saved to s3 - as a zero byte file. Then, that updated path (if need be due to AWS_S3_FILE_OVERWRITE) will be used in uploading the file.