Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chemical Analysis Workflow broken in disco #1326

Closed
aarongundel opened this issue Sep 22, 2023 · 2 comments · Fixed by #1336 or archesproject/arches#10110
Closed

Chemical Analysis Workflow broken in disco #1326

aarongundel opened this issue Sep 22, 2023 · 2 comments · Fixed by #1336 or archesproject/arches#10110
Assignees
@aarongundel

Comments

@aarongundel
Copy link
Contributor

The CA workflow is broken in disco. Looks like the reason is that the companion modification for uppy made in afs's webpack.common.js didn't make it into disco. However, there the PR for companion's fix did merge into uppy - so it may be as simple as upgrading uppy to fix this. If not, we'll have to modify the webpack process to replace companion again.
@jacobtylerwalls jacobtylerwalls moved this to 🔖 Ready in afs-pipeline Sep 22, 2023
@aarongundel aarongundel moved this from 🔖 Ready to 🏗 In progress in afs-pipeline Sep 25, 2023
@aarongundel
Copy link
Contributor Author

This is preparing for release on the uppy side. Rather than hotfix this and point directly at GH - this should wait for a new release for uppy - generally every week/2 weeks.

@aarongundel aarongundel moved this from 🏗 In progress to 📋 On hold in afs-pipeline Sep 25, 2023
@aarongundel
Copy link
Contributor Author

A new release was posted 8 hours ago, so this is good to go.

@aarongundel aarongundel moved this from 📋 On hold to 🔖 Ready in afs-pipeline Sep 29, 2023
@aarongundel aarongundel moved this from 🔖 Ready to 🏗 In progress in afs-pipeline Sep 29, 2023
This was linked to pull requests Oct 3, 2023
fix for chemical analysis workflow #1336
Merged
removes the switching of file storage archesproject/arches#10110
Merged
@aarongundel aarongundel moved this from 🏗 In progress to 👀 In review in afs-pipeline Oct 3, 2023
@chiatt chiatt closed this as completed Oct 13, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in afs-pipeline Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarongundel aarongundel

Labels
None yet
Projects
afs-pipeline
Status: ✅ Done
Milestone
No milestone
2 participants
@aarongundel @chiatt