Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 1.6 dev #984

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Update version to 1.6 dev #984

merged 2 commits into from
Dec 19, 2023

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Dec 18, 2023

Still struggle to figure out whether it should be 1.6 or 2.0.

@aprokop aprokop changed the title Update version to 1.6 dev Update version to 2.0 dev Dec 18, 2023
@aprokop
Copy link
Contributor Author

aprokop commented Dec 18, 2023

One thing is that we still have SameMajorVersion compatibility, and not AnyNewerVersion. Not sure whether we want to switch.

@Rombur
Copy link
Collaborator

Rombur commented Dec 18, 2023

Still struggle to figure out whether it should be 1.6 or 2.0.

We found out in deal.II that it's a lot easier to decide before the release to go from 1.6 to 2.0 than the other way around because downstream app may decide to differentiate their code on the major version as soon as we update the version to 2.0

One thing is that we still have SameMajorVersion compatibility, and not AnyNewerVersion. Not sure whether we want to switch.

We should use AnyNewerVersion and let the user decide what to do. SameMajorVersion is too restrictive.

@masterleinad
Copy link
Collaborator

We should use AnyNewerVersion and let the user decide what to do. SameMajorVersion is too restrictive.

I agree.

@aprokop aprokop changed the title Update version to 2.0 dev Update version to 1.6 dev Dec 18, 2023
@aprokop
Copy link
Contributor Author

aprokop commented Dec 19, 2023

Unrelated failures in distributed test (sporadic).

@aprokop aprokop merged commit 2311f90 into arborx:master Dec 19, 2023
1 of 2 checks passed
@aprokop aprokop deleted the update_version branch December 19, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants