-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake AnyNewerVersion
-> SameMajorVersion
#1188
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we conditionally us a version range when cmake is recent enough and we defer the actual update of our cmake minimum requirement?
This means that users cannot support both 1.x and 2.x versions in their own code. That's going to be a pain. |
For the current CMake, we switch to
|
I want to be able to require a minimum version because older versions did not have ray tracing. |
Why not require ArborX 2.0? Though, that would likely only work for something small like Adamantine. Not sure about deal.II. |
Yes, I could live with |
We are not backwards compatible for version 2.0. Allowing users' 1.x code to build against 2.0 is almost 100% would lead to build failures. Would rather prevent that during configuration.
Switching to
SameMajorVersion
would likely be temporary, for a few 2.x releases, after which we would switch back.An alternative to switching to
SameMajorVersion
would be to update CMake requirements to at least 3.19 (release 11/18/2020, so about a year older than CMake we are using right now) and doThis has a benefit of not having to revisit this again later.
Note:
AnyNewerVersion
was introduced in #984.