begin to add tests for apis/storage/v1alpha

Makefile

@@ -216,6 +216,7 @@ run-unit-tests: $(GOBUILDDIR) $(SOURCES)
 		golang:$(GOVERSION) \
 		go test $(TESTVERBOSEOPTIONS) \
 			$(REPOPATH)/pkg/apis/deployment/v1alpha \
+			$(REPOPATH)/pkg/apis/storage/v1alpha \
 			$(REPOPATH)/pkg/deployment/reconcile \
 			$(REPOPATH)/pkg/deployment/resources \
 			$(REPOPATH)/pkg/util/k8sutil \

pkg/apis/storage/v1alpha/local_storage_spec_test.go

@@ -0,0 +1,64 @@
+//
+// DISCLAIMER
+//
+// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// Copyright holder is ArangoDB GmbH, Cologne, Germany
+//
+// Author Jan Christoph Uhde
+//
+
+package v1alpha
+
+import (
+	"testing"
+
+	"github.com/pkg/errors"
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_LocalStorageSpec_Creation(t *testing.T) {
+	var (
+		class StorageClassSpec
+		local LocalStorageSpec
+		err   error
+	)
+
+	class = StorageClassSpec{"SpecName", true}
+	local = LocalStorageSpec{StorageClass: class, LocalPath: []string{""}}
+	err = local.Validate()
+	assert.Equal(t, errors.Cause(class.Validate()), errors.Cause(err))
+
+	class = StorageClassSpec{"spec-name", true}
+	local = LocalStorageSpec{StorageClass: class, LocalPath: []string{""}} //is this allowed - should the paths be checked?
+	err = local.Validate()
+	assert.Equal(t, nil, errors.Cause(err))
+
+	class = StorageClassSpec{"spec-name", true}
+	local = LocalStorageSpec{StorageClass: class, LocalPath: []string{}}
+	err = local.Validate()
+	assert.Equal(t, ValidationError, errors.Cause(err)) //path empty
+}
+
+func Test_LocalStorageSpec_Reset(t *testing.T) {
+	class := StorageClassSpec{"spec-name", true}
+	source := LocalStorageSpec{StorageClass: class, LocalPath: []string{"/a/path", "/another/path"}}
+	target := LocalStorageSpec{}
+	resetImmutableFieldsResult := source.ResetImmutableFields(&target)
+	expected := []string{"storageClass.name", "localPath"}
+	assert.Equal(t, expected, resetImmutableFieldsResult)
+	assert.Equal(t, source.LocalPath, target.LocalPath)
+	assert.Equal(t, source.StorageClass.Name, target.StorageClass.Name)
+}

pkg/apis/storage/v1alpha/local_storage_test.go

@@ -0,0 +1,33 @@
+//
+// DISCLAIMER
+//
+// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// Copyright holder is ArangoDB GmbH, Cologne, Germany
+//
+// Author Jan Christoph Uhde
+//
+
+package v1alpha
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_ArangoLocalStorage_Creation(t *testing.T) {
+	assert.True(t, true)
+}

pkg/apis/storage/v1alpha/storage_class_spec_test.go

@@ -0,0 +1,55 @@
+//
+// DISCLAIMER
+//
+// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// Copyright holder is ArangoDB GmbH, Cologne, Germany
+//
+// Author Jan Christoph Uhde
+//
+
+package v1alpha
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_StorageClassSpec_Creation(t *testing.T) {
+	storageClassSpec := StorageClassSpec{}
+	assert.True(t, nil != storageClassSpec.Validate())
+
+	storageClassSpec = StorageClassSpec{Name: "TheSpecName", IsDefault: true} // no upper-case allowed
+	assert.True(t, nil != storageClassSpec.Validate())
+
+	storageClassSpec = StorageClassSpec{"the-spec-name", true}
+	assert.Equal(t, nil, storageClassSpec.Validate())
+
+	storageClassSpec = StorageClassSpec{} // this is invalid because it was not created with a proper name
+	storageClassSpec.SetDefaults("foo")   // here the Name is fixed
+	assert.Equal(t, nil, storageClassSpec.Validate())
+}
+
+func Test_StorageClassSpec_ResetImmutableFileds(t *testing.T) {
+	specSource := StorageClassSpec{"source", true}
+	specTarget := StorageClassSpec{"target", true}
+
+	assert.Equal(t, "target", specTarget.Name)
+	rv := specSource.ResetImmutableFields("fieldPrefix-", &specTarget)
+	assert.Equal(t, "fieldPrefix-name", strings.Join(rv[:], ", "))
+	assert.Equal(t, "source", specTarget.Name)
+}