begin to add tests for apis/storage/v1alpha
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObiWahn
force-pushed
the
tests/apis-storage-v1alpha
branch
3 times, most recently
from
e74bb38 to
9b7c610
Compare
ObiWahn
force-pushed
the
tests/apis-storage-v1alpha
branch
from
9b7c610 to
8118132
Compare
ObiWahn
force-pushed
the
tests/apis-storage-v1alpha
branch
from
8118132 to
97afe56
Compare
…v1alpha * origin/master: (145 commits) Enable LONG on kube-arangodb-long test fix rocksdb_encryption_test fix - /api/version will answer on all servers (not leader only) fixes required after merge add downgrade tests add missing uniuri Merged in master Fixed unit-test packages Fixed unit tests Do not Fail the deployment, unless there is REALLY no other way Updated tests Refactor DeploymentState to DeploymentPhase Revert example change Added detection on unschedulable pods Detect pods not being scheduled Same fix on ArangoLocalStorage AsOwner no longer things the owner refers to a controller. It refers to the ArangoDeployment disable upgrade tests to 3.4 until 3.4 is available on hub.docker.com Listen for secret changes Log improvements ...
ewoutp
suggested changes
Mar 29, 2018
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func Test_LocalStorageSpec_Creation(t *testing.T) { |
There was a problem hiding this comment.
Avoid the use of underscore in member names.
| ) | ||
|
|
||
| func Test_LocalStorageSpec_Creation(t *testing.T) { | ||
| var ( |
There was a problem hiding this comment.
Drop this and do something like class := ... on first use
|
|
||
| class = StorageClassSpec{"SpecName", true} | ||
| local = LocalStorageSpec{StorageClass: class, LocalPath: []string{""}} | ||
| err = local.Validate() |
There was a problem hiding this comment.
Don't understand this and the next line.
Probably you want to use assert.Error or assert.NoError see https://godoc.org/github.com/stretchr/testify/assert#Error
| assert.Equal(t, errors.Cause(class.Validate()), errors.Cause(err)) | ||
|
|
||
| class = StorageClassSpec{"spec-name", true} | ||
| local = LocalStorageSpec{StorageClass: class, LocalPath: []string{""}} //is this allowed - should the paths be checked? |
| assert.True(t, nil != storageClassSpec.Validate()) | ||
|
|
||
| storageClassSpec = StorageClassSpec{Name: "TheSpecName", IsDefault: true} // no upper-case allowed | ||
| assert.True(t, nil != storageClassSpec.Validate()) |
ewoutp
suggested changes
Mar 29, 2018
|
|
||
| class := StorageClassSpec{"SpecName", true} | ||
| local := LocalStorageSpec{StorageClass: class, LocalPath: []string{""}} | ||
| err := local.Validate() |
There was a problem hiding this comment.
Merge with line 39.
assert.Error(t, local.Validate())
| class = StorageClassSpec{"spec-name", true} | ||
| local = LocalStorageSpec{StorageClass: class, LocalPath: []string{}} | ||
| err = local.Validate() | ||
| assert.Equal(t, ValidationError, errors.Cause(err)) |
There was a problem hiding this comment.
assert.IsTrue(t, IsValidation(err))
| ) | ||
|
|
||
| func TestArangoLocalStorageCreation(t *testing.T) { | ||
| assert.True(t, false, "test needs to be implemented") |
|
|
||
| assert.Equal(t, "target", specTarget.Name) | ||
| rv := specSource.ResetImmutableFields("fieldPrefix-", &specTarget) | ||
| assert.Equal(t, "fieldPrefix-name", strings.Join(rv[:], ", ")) |
There was a problem hiding this comment.
go: no need for rv[:], just rv is enough here
ObiWahn
force-pushed
the
tests/apis-storage-v1alpha
branch
2 times, most recently
from
f0b34b4 to
04305ef
Compare
ObiWahn
force-pushed
the
tests/apis-storage-v1alpha
branch
from
04305ef to
8a59df6
Compare
ewoutp
reviewed
Mar 29, 2018
|
|
||
| // test creation of arango local storage | ||
| func TestArangoLocalStorageCreation(t *testing.T) { | ||
| // REVIEW - is there something more meaningful to test |
There was a problem hiding this comment.
IMO this is testing go and not our code.
I suggest to drop it.
ewoutp
reviewed
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests for
apis/storage/v1alphapart of issue #33