Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: deploy v1.3.0 #509

Merged
merged 9 commits into from
Dec 12, 2023
Merged

release: deploy v1.3.0 #509

merged 9 commits into from
Dec 12, 2023

Conversation

mathewmeconry
Copy link
Contributor

@mathewmeconry mathewmeconry commented Dec 12, 2023 •
edited
Loading

Description

Releases v1.3.0 from v1.3.0-rc0.4.

The active_contracts.json includes now all bases and implementations

Ending with _Implementation means it is a proxy and this is the implementation used by the proxy
Example:
managingDAO is a proxy and managingDAO_Implementation is the implementation used by this proxy

Ending with Implementation means this is the implementation used to create a new contract
Example:
MultisigPluginSetup is the plugin setup for the MultisigPlugin which uses MultisigPluginSetupImplementation to tell the PluginSetupProcessor which implementation it should use during plugin preparation.
If we would track the plugin installations in this file this would result in the entries MultisigPlugin and MultisigPlugin_Implementation whereas the MultisigPlugin got created by the PluginSetupProcessor and MultisigPlugin_Implementation being equal to MultisigPluginSetupImplementation

Ending with Base means this is the base/implementation used to create a new contract
Example:
The DAOFactory used the DAOBase to create a new DAO.
If we would track the newly created DAOs in this file this would result in an entry called DAO and DAO_Implementation whereas DAO would be the proxy that got created by the DAOFactory and DAO_Implementation being the implementation used by said proxy.

Task ID: OS-?

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@mathewmeconry mathewmeconry changed the title Feat/deploy v1.3.0 release: deploy v1.3.0 Dec 12, 2023
@github-actions github-actions bot removed the subgraph label Dec 12, 2023
heueristik
heueristik approved these changes Dec 12, 2023
View reviewed changes
packages/contracts/CHANGELOG.md Show resolved Hide resolved
@mathewmeconry mathewmeconry merged commit e90ea8f into main Dec 12, 2023
16 checks passed
mathewmeconry added a commit that referenced this pull request Dec 12, 2023
@mathewmeconry
Revert "release: deploy v1.3.0 (#509)"
6742501 
This reverts commit e90ea8f.
@heueristik heueristik mentioned this pull request Dec 12, 2023
Merged
9 tasks
heueristik added a commit that referenced this pull request Dec 20, 2023
@heueristik @mathewmeconry
docs: add audit reports for v1.3.0 for develop (#513)
852d802 
* fix(subgraph): update to @graphprotocol/[email protected] (#453)

* fix: missing virtual keyword (#452)

* fix: added missing virtual keywords.

* fix: correct misspelled filename

* docs: improved NatSpec

* chore: bump package versions

* Update packages/contracts/CHANGELOG.md

Co-authored-by: Mathias Scherer <[email protected]>

---------

Co-authored-by: Mathias Scherer <[email protected]>

* Deploy contracts and subgraph to sepolia (#475)

* feat: deploy v1.3.0-rc0 to sepolia

* feat: bump subgraph version to v1.3.0-rc0
feat: deploy sepolia subgraph

* fix(OS-638): fixes typo in implementation

* chore: fix formatting in helpers script

* fix: ipfs returned an empty string (#485) (#495)

* chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496)

* chore: prepared arbitrum deployment

* chore: deployed v1.3.0 to arbitrumGoerli

* docs: improved checklist

* chore: deployed v1.3.0 to arbitrum

* chore: deployed v1.3.0-rc0.4 npm packages

* chore: added manifests for arbitrum and arbitrumGoerli

* docs: improved deployment checklist

* docs: improved deployment checklist

* docs: fix typo

Co-authored-by: Mathias Scherer <[email protected]>

---------

Co-authored-by: Mathias Scherer <[email protected]>

* docs: v1.3.0 audit files

* release: deploy v1.3.0 (#509)

* docs(contracts): removes outdated step in upgrade checklist

* deploy(contracts): adds v1.3.0 mainnet deployment

* deploy(contracts): adds polygon deployment

* fix: removes uncessary inconsistent managingDAOImplementation field from active_contracts.json

* chore: bump package version to v1.3.0

* chore: updates version for osx package

* chore(contracts): updates changelog

* chore(contracts): updates active_contracts with implementations and bases

* chore(contracts): moves line in changelog

* docs: replace code4rena draft by final report

* docs: mention audit reports in README

* docs: added missing report link and use perma links

---------

Co-authored-by: Mathias Scherer <[email protected]>
mathewmeconry added a commit that referenced this pull request Jan 4, 2024
@mathewmeconry @heueristik
feat: deploys on base and arbitrum sepolia (merge back) (#517)
f86bd39 
* fix(subgraph): update to @graphprotocol/[email protected] (#453)

* fix: missing virtual keyword (#452)

* fix: added missing virtual keywords.

* fix: correct misspelled filename

* docs: improved NatSpec

* chore: bump package versions

* Update packages/contracts/CHANGELOG.md

Co-authored-by: Mathias Scherer <[email protected]>

---------

Co-authored-by: Mathias Scherer <[email protected]>

* Deploy contracts and subgraph to sepolia (#475)

* feat: deploy v1.3.0-rc0 to sepolia

* feat: bump subgraph version to v1.3.0-rc0
feat: deploy sepolia subgraph

* fix(OS-638): fixes typo in implementation

* chore: fix formatting in helpers script

* fix: ipfs returned an empty string (#485) (#495)

* chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496)

* chore: prepared arbitrum deployment

* chore: deployed v1.3.0 to arbitrumGoerli

* docs: improved checklist

* chore: deployed v1.3.0 to arbitrum

* chore: deployed v1.3.0-rc0.4 npm packages

* chore: added manifests for arbitrum and arbitrumGoerli

* docs: improved deployment checklist

* docs: improved deployment checklist

* docs: fix typo

Co-authored-by: Mathias Scherer <[email protected]>

---------

Co-authored-by: Mathias Scherer <[email protected]>

* release: deploy v1.3.0 (#509)

* docs(contracts): removes outdated step in upgrade checklist

* deploy(contracts): adds v1.3.0 mainnet deployment

* deploy(contracts): adds polygon deployment

* fix: removes uncessary inconsistent managingDAOImplementation field from active_contracts.json

* chore: bump package version to v1.3.0

* chore: updates version for osx package

* chore(contracts): updates changelog

* chore(contracts): updates active_contracts with implementations and bases

* chore(contracts): moves line in changelog

* fix: build and release metadata mixups (#507)

* fix: build and release metadata where swapped

* fix: publish an empty JSON object to silence the EmptyReleaseMetadata error

* docs: improve checklists

* deploy: adds fqn to contract verification

* deploy: corrects false fqds

* chore: applies prettier formatting

* chore: adds arbitrum sepolia deployment

* deploy(subgraph): changes node endpoint to alchemy

* feat: deploys base sepolia
fix: sets fixed gas price for base networks
fix: fixes wrong multisig address for arbitrum sepolia management dao

* chore: adds release.md hr line

Co-authored-by: Michael Heuer <[email protected]>

* style: applies prettier formatting

---------

Co-authored-by: Michael Heuer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewmeconry @Rekard0 @heueristik