fix: empty metadata caused by IPFS upload returning an empty string #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rekard0
approved these changes
Oct 30, 2023
mathewmeconry
added a commit
that referenced
this pull request
Nov 30, 2023
* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> * chore: fix merge --------- Co-authored-by: Mathias Scherer <[email protected]>
mathewmeconry
added a commit
that referenced
this pull request
Dec 12, 2023
* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * docs(contracts): removes outdated step in upgrade checklist * deploy(contracts): adds v1.3.0 mainnet deployment * deploy(contracts): adds polygon deployment * fix: removes uncessary inconsistent managingDAOImplementation field from active_contracts.json * chore: bump package version to v1.3.0 * chore: updates version for osx package * chore(contracts): updates changelog * chore(contracts): updates active_contracts with implementations and bases * chore(contracts): moves line in changelog * style(contracts): applies prettier styling --------- Co-authored-by: Michael Heuer <[email protected]>
heueristik
added a commit
that referenced
this pull request
Dec 20, 2023
* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * docs: v1.3.0 audit files * release: deploy v1.3.0 (#509) * docs(contracts): removes outdated step in upgrade checklist * deploy(contracts): adds v1.3.0 mainnet deployment * deploy(contracts): adds polygon deployment * fix: removes uncessary inconsistent managingDAOImplementation field from active_contracts.json * chore: bump package version to v1.3.0 * chore: updates version for osx package * chore(contracts): updates changelog * chore(contracts): updates active_contracts with implementations and bases * chore(contracts): moves line in changelog * docs: replace code4rena draft by final report * docs: mention audit reports in README * docs: added missing report link and use perma links --------- Co-authored-by: Mathias Scherer <[email protected]>
heueristik
added a commit
that referenced
this pull request
Dec 20, 2023
* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * fix: build and release metadata where swapped * fix: publish an empty JSON object to silence the EmptyReleaseMetadata error * docs: improve checklists --------- Co-authored-by: Mathias Scherer <[email protected]>
mathewmeconry
added a commit
that referenced
this pull request
Jan 4, 2024
* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * release: deploy v1.3.0 (#509) * docs(contracts): removes outdated step in upgrade checklist * deploy(contracts): adds v1.3.0 mainnet deployment * deploy(contracts): adds polygon deployment * fix: removes uncessary inconsistent managingDAOImplementation field from active_contracts.json * chore: bump package version to v1.3.0 * chore: updates version for osx package * chore(contracts): updates changelog * chore(contracts): updates active_contracts with implementations and bases * chore(contracts): moves line in changelog * fix: build and release metadata mixups (#507) * fix: build and release metadata where swapped * fix: publish an empty JSON object to silence the EmptyReleaseMetadata error * docs: improve checklists * deploy: adds fqn to contract verification * deploy: corrects false fqds * chore: applies prettier formatting * chore: adds arbitrum sepolia deployment * deploy(subgraph): changes node endpoint to alchemy * feat: deploys base sepolia fix: sets fixed gas price for base networks fix: fixes wrong multisig address for arbitrum sepolia management dao * chore: adds release.md hr line Co-authored-by: Michael Heuer <[email protected]> * style: applies prettier formatting --------- Co-authored-by: Michael Heuer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #485
Type of change
Checklist:
CHANGELOG.mdfile in the root folder.DEPLOYMENT_CHECKLISTfile in the root folder.UPDATE_CHECKLISTfile in the root folder.